Skip to content

Commit

Permalink
ncmpc 0.51
Browse files Browse the repository at this point in the history 
Signed-off-by: Rui Chen <[email protected]>

Co-authored-by: Carlo Cabrera <[email protected]>
  • Loading branch information
@chenrui333 @carlocab
chenrui333 and carlocab committed Jan 5, 2025
1 parent 2e17440 commit 6df0896
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/autobump.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2123,6 +2123,7 @@ nbdime
ncc
ncdc
ncdu
ncmpc
ncmpcpp
ncnn
nco
Expand Down
31 changes: 25 additions & 6 deletions Formula/n/ncmpc.rb
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Ncmpc < Formula
desc "Curses Music Player Daemon (MPD) client"
homepage "https://www.musicpd.org/clients/ncmpc/"
url "https://www.musicpd.org/download/ncmpc/0/ncmpc-0.49.tar.xz"
sha256 "65bbec0ede9e6bcf62ac647b0c706485beb2bdd5db70ca8d60103f32f162cf29"
url "https://www.musicpd.org/download/ncmpc/0/ncmpc-0.51.tar.xz"
sha256 "e74be00e69bc3ed1268cafcc87274e78dfbde147f2480ab0aad8260881ec7271"
license "GPL-2.0-or-later"

livecheck do
Expand All @@ -24,19 +24,24 @@ class Ncmpc < Formula
end

depends_on "boost" => :build
depends_on "gettext" => :build
depends_on "meson" => :build
depends_on "ninja" => :build
depends_on "pkgconf" => :build
depends_on "gettext"

depends_on "fmt"
depends_on "libmpdclient"
depends_on "pcre2"

uses_from_macos "ncurses"

on_macos do
depends_on "llvm" => :build if DevelopmentTools.clang_build_version <= 1300
depends_on "gettext"
depends_on "llvm" if DevelopmentTools.clang_build_version <= 1500
end

fails_with :clang do
build 1300
build 1500
cause "Requires C++20"
end

Expand All @@ -46,7 +51,21 @@ class Ncmpc < Formula
end

def install

Check failure on line 53 in Formula/n/ncmpc.rb

View workflow job for this annotation

GitHub Actions / macOS 13-arm64

`brew install --verbose --formula --build-bottle ncmpc` failed on macOS Ventura (13) on Apple Silicon! 

      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::__1::system_error>(std::__1::system_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
  "___cxa_init_primary_exception", referenced from:
      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::runtime_error>(std::runtime_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::__1::system_error>(std::__1::system_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /opt/homebrew/Library/Homebrew/shims/mac/super/ninja -C /private/tmp/ncmpc-20250104-8700-r4qs08/ncmpc-0.51/build -v

==> Formula
Path: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/n/ncmpc.rb
==> Configuration
HOMEBREW_VERSION: 4.4.14-42-gb6fafba
ORIGIN: https://github.com/Homebrew/brew
HEAD: b6fafba4864d65acabf966415e14b2dd86d81e1a
Last commit: 2 hours ago
Branch: master
Core tap HEAD: 0a87a8f530cef70cdc4c4b452e99ad92039601ad
Core tap last commit: 8 minutes ago
Core tap JSON: 05 Jan 04:37 UTC
Core cask tap JSON: 05 Jan 04:37 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_BOOTSNAP: set
HOMEBREW_CACHE: /Users/brew/Library/Caches/Homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_COLOR: set
HOMEBREW_CURL_PATH: /usr/bin/curl
HOMEBREW_FAIL_LOG_LINES: 150
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_GIT_EMAIL: [email protected]
HOMEBREW_GIT_NAME: BrewTestBot
HOMEBREW_GIT_PATH: /usr/bin/git
HOMEBREW_LOGS: /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_EMOJI: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
HOMEBREW_VERIFY_ATTESTATIONS: set
Homebrew Ruby: 3.3.6 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: quad-core 64-bit dunno
Clang: 15.0.0 build 1500
Git: 2.39.3 => /usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 13.7-arm64
CLT: 15.1.0.0.1.1700200546
Xcode: 15.2
Rosetta 2: false
==> ENV
HOMEBREW_CC: llvm_clang
HOMEBREW_CXX: llvm_clang++
LDFLAGS: -L/opt/homebrew/opt/llvm/lib/c++
-L/opt/homebrew/opt/llvm/lib
-Wl,-rpath,/opt/homebrew/opt/llvm/lib/c++
-Wl,-rpath,/opt/homebrew/opt/llvm/lib
MAKEFLAGS: -j4
CMAKE_PREFIX_PATH: /opt/homebrew/opt/readline:/opt/homebrew/opt/sqlite:/opt/homebrew/opt/llvm:/opt/homebrew
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
CMAKE_FRAMEWORK_PATH: /opt/homebrew/opt/[email protected]/Frameworks
PKG_CONFIG_PATH: /opt/homebrew/opt/pkgconf/lib/pkgconfig:/opt/homebrew/opt/fmt/lib/pkgconfig:/opt/homebrew/opt/libmpdclient/lib/pkgconfig:/opt/homebrew/opt/pcre2/lib/pkgconfig:/opt/homebrew/opt/mpdecimal/lib/pkgconfig:/opt/homebrew/opt/openssl@3/lib/pkgconfig:/opt/homebrew/opt/readline/lib/pkgconfig:/opt/homebrew/opt/sqlite/lib/pkgconfig:/opt/homebrew/opt/xz/lib/pkgconfig:/opt/homebrew/opt/[email protected]/lib/pkgconfig:/opt/homebrew/opt/z3/lib/pkgconfig:/opt/homebrew/opt/lz4/lib/pkgconfig:/opt/homebrew/opt/zstd/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/opt/homebrew/Library/Homebrew/os/mac/pkgconfig/13
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_GIT: /usr/bin/git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk
ACLOCAL_PATH: /opt/homebrew/share/aclocal
PATH: /opt/homebrew/opt/llvm/bin:/opt/homebrew/Library/Homebrew/shims/mac/super:/opt/homebrew/opt/gettext/bin:/opt/homebrew/opt/meson/bin:/opt/homebrew/opt/ninja/bin:/opt/homebrew/opt/pkgconf/bin:/opt/homebrew/opt/pcre2/bin:/opt/homebrew/opt/openssl@3/bin:/opt/homebrew/opt/sqlite/bin:/opt/homebrew/opt/xz/bin:/opt/homebrew/opt/

Check failure on line 53 in Formula/n/ncmpc.rb

View workflow job for this annotation

GitHub Actions / macOS 13-x86_64

`brew install --verbose --formula --build-bottle ncmpc` failed on macOS Ventura (13)! 

      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::__1::system_error>(std::__1::system_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
  "___cxa_init_primary_exception", referenced from:
      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::runtime_error>(std::runtime_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
      std::exception_ptr std::make_exception_ptr[abi:fe190106]<std::__1::system_error>(std::__1::system_error) in libclient.a(.._event_net_ConnectSocket.cxx.o)
ld: symbol(s) not found for architecture x86_64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/ninja -C /private/tmp/ncmpc-20250105-8607-85xwrx/ncmpc-0.51/build -v

==> Formula
Path: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/n/ncmpc.rb
==> Configuration
HOMEBREW_VERSION: 4.4.14-42-gb6fafba
ORIGIN: https://github.com/Homebrew/brew
HEAD: b6fafba4864d65acabf966415e14b2dd86d81e1a
Last commit: 3 hours ago
Branch: master
Core tap HEAD: 0a87a8f530cef70cdc4c4b452e99ad92039601ad
Core tap last commit: 13 minutes ago
Core tap JSON: 05 Jan 04:39 UTC
Core cask tap JSON: 05 Jan 04:39 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BOOTSNAP: set
HOMEBREW_CACHE: /Users/brew/Library/Caches/Homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_COLOR: set
HOMEBREW_CURL_PATH: /usr/bin/curl
HOMEBREW_FAIL_LOG_LINES: 150
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_GIT_EMAIL: [email protected]
HOMEBREW_GIT_NAME: BrewTestBot
HOMEBREW_GIT_PATH: /usr/bin/git
HOMEBREW_LOGS: /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs
HOMEBREW_MAKE_JOBS: 6
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_EMOJI: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
HOMEBREW_VERIFY_ATTESTATIONS: set
Homebrew Ruby: 3.3.6 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: hexa-core 64-bit penryn
Clang: 15.0.0 build 1500
Git: 2.39.3 => /usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 13.7-x86_64
CLT: 15.1.0.0.1.1700200546
Xcode: 15.2
==> ENV
HOMEBREW_CC: llvm_clang
HOMEBREW_CXX: llvm_clang++
LDFLAGS: -L/usr/local/opt/llvm/lib/c++
-L/usr/local/opt/llvm/lib
-Wl,-rpath,/usr/local/opt/llvm/lib/c++
-Wl,-rpath,/usr/local/opt/llvm/lib
MAKEFLAGS: -j6
CMAKE_PREFIX_PATH: /usr/local/opt/readline:/usr/local/opt/sqlite:/usr/local/opt/llvm:/usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
CMAKE_FRAMEWORK_PATH: /usr/local/opt/[email protected]/Frameworks
PKG_CONFIG_PATH: /usr/local/opt/pkgconf/lib/pkgconfig:/usr/local/opt/fmt/lib/pkgconfig:/usr/local/opt/libmpdclient/lib/pkgconfig:/usr/local/opt/pcre2/lib/pkgconfig:/usr/local/opt/mpdecimal/lib/pkgconfig:/usr/local/opt/openssl@3/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/xz/lib/pkgconfig:/usr/local/opt/[email protected]/lib/pkgconfig:/usr/local/opt/z3/lib/pkgconfig:/usr/local/opt/lz4/lib/pkgconfig:/usr/local/opt/zstd/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/13
HOMEBREW_MAKE_JOBS: 6
HOMEBREW_GIT: /usr/bin/git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/opt/llvm/bin:/usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/local/opt/gettext/bin:/usr/local/opt/meson/bin:/usr/local/opt/ninja/bin:/usr/local/opt/pkgconf/bin:/usr/local/opt/pcre2/bin:/usr/local/opt/openssl@3/bin:/usr/local/opt/sqlite/bin:/usr/local/opt/xz/bin:/usr/local/opt/[email protected]/bin:/usr/local/opt/z3/bin:/usr/local/opt/lz4/bin:/usr/local/opt/zstd/bin:
ENV.llvm_clang if OS.mac? && (DevelopmentTools.clang_build_version <= 1300)
if OS.mac? && (DevelopmentTools.clang_build_version <= 1500)
ENV.prepend_path "PATH", Formula["llvm"].opt_bin
ENV.llvm_clang

# Work around failure mixing newer `llvm` headers with older Xcode's libc++:
# Undefined symbols for architecture arm64:
# "std::exception_ptr::__from_native_exception_pointer(void*)", referenced from:
# std::exception_ptr std::make_exception_ptr[abi:fe190100]<std::runtime_error>(std::runtime_error)...
ENV.append "LDFLAGS", <<~EOS
-L#{Formula["llvm"].opt_lib}/c++
-L#{Formula["llvm"].opt_lib}
-Wl,-rpath,#{Formula["llvm"].opt_lib}/c++
-Wl,-rpath,#{Formula["llvm"].opt_lib}
EOS
end

system "meson", "setup", "build", "-Dcolors=false", "-Dnls=enabled", "-Dregex=enabled", *std_meson_args
system "meson", "compile", "-C", "build", "--verbose"
Expand Down

0 comments on commit 6df0896

Please sign in to comment.