Intensity data not being published fix #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue we've had with the reliability of publishing intensity data. The problem is the is_intensity_supported() function. We've had a few different cases where this function fails for sensors that do support intensity data:
As the driver only tries this test once it's possible for you to end up with no intensity data being published on a sensor that does support it. We're using the intensity data for mission critical functions on our robot so it's really important it's always present.
I've added this fix which will retry the is_intensity_supported() check a few times (using the error_count and error_limit so it does a fixed number of attempts). We've found this a reliable method to ensure we always have intensity data from our sensors.