Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 별점 및 거리 뜨도록 구현 #31

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

world2222
Copy link
Collaborator

Now on the recommend page, you can not only get the info with the name of the cafe but also the rate and distance from current location. Also, refactored codes from 'Recommend.dart'. Now it gets each lists that it got from api url as parameter. Lastly, refactored a bit from 'recommend_title_text_enum.dart'. Changed all the 'Text' and 'SubText' to 'Title' and 'SubTitle' for better recognition.

Screenshot

image

Motivation

  • api url을 통해 받아온 리스트를 직접 파라미터로 전달하여 Recommend.dart 파일 내에서 처리할 수 있도록 하였습니다.
  • Recommend.dart가 파라미터로 전달 받은 리스트를 활용하여 별점과 거리를 나타낼 수 있도록 하였습니다.
  • recommend_title_text_enum.dart 파일에서 혼란 방지를 위해 'Text'와 'SubText'를 각각 'Title'과 'SubTitle'로 바꾸었습니다.

To Reviewers

  • 'Recommend.dart', 'recommend_title_text_enum.dart' 파일을 중점적으로 확인해주세요.
  • lib/component/future_builder 폴더의 future builder 파일들이 필요가 없을 것 같습니다. 다음 커밋 때도 쓸 일이 없어지면 해당 폴더를 삭제하도록 하겠습니다.
  • .env와 관련하여 제 노트북이 hipspot을 실행하는 데에 문제가 발생하였습니다. 코드 자체에는 문제가 없는데 'No file or variants found for asset: .env.'라는 문구가 계속 뜹니다. 그래서 기존에 작업했던 코드들은 모두 feat/issue-20에 Test라는 제목으로 commit해 놓은 후 다시 바뀐 파일만 develop 에서 가져온 코드에 덮어 씌움으로써 코드를 완료하였습니다.

world2222 added 2 commits May 20, 2023 16:56
Now on the recommend page, you can not only get the info with the name
of the cafe but also the rate and distance from current location. Also,
refactored codes from 'Recommend.dart'. Now it gets each lists that it
got from api url as parameter. Lastly, refactored a bit from
'recommend_title_text_enum.dart'. Changed all the 'Text' and 'SubText'
to 'Title' and 'SubTitle' for better recognition.
Now on the recommend page, you can not only get the info with the name
of the cafe but also the rate and distance from current location. Also,
refactored codes from 'Recommend.dart'. Now it gets each lists that it
got from api url as parameter. Lastly, refactored a bit from
'recommend_title_text_enum.dart'. Changed all the 'Text' and 'SubText'
to 'Title' and 'SubTitle' for better recognition.
@world2222 world2222 requested a review from Sangjun-man as a code owner May 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant