This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement filesystem functions for node.js #19
Implement filesystem functions for node.js #19
Changes from all commits
58eea18
3d712cd
e0d23c3
b658eb1
dcfeb82
e1ef4e5
9f3560a
36c7048
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me an idea; we should probably translate errors inside platform support.
filesystem.capabilities
is meant to represent more significant filesystem differences (ex: puter directories can be associated with subdomains, ACL vs POSIX-style permissions, etc)I like the idea of having an object called
ERR_NO_ENTITY
(could have properties likeposixLabel: 'ENOENT'
,description: '...'
) - then it's just an object reference comparison instead of a string comparison here too.I might merge this first and then we can change this after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! The less the builtins have to know/care about the platform, the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any documentation for Puter SDK errors. I'd need to know their codes to be able to translate them - and generally it would be useful for API users if https://docs.puter.com listed the errors for each API call.