Extraneous eval in iterator macro #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This evaluation was causing precompilation failures when attempting to use the `@programiterator` macro in external packages such as the `Garden`. I believe its inclusion actually makes the check for the supertype being a subtype of `ProgramIterator` incorrect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 71.26% 71.22% -0.05%
==========================================
Files 20 19 -1
Lines 689 688 -1
==========================================
- Hits 491 490 -1
Misses 198 198 ☔ View full report in Codecov by Sentry. |
THinnerichs
approved these changes
Feb 18, 2025
|
Good job! This works very well indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This evaluation was causing precompilation failures when attempting to use the
@programiteratormacro in external packages such as theGarden. I believe its inclusion actually makes the check (that checks whether the supertype is a subtype ofProgramIterator) incorrect.I also added a test for the case when the macro is used incorrectly.