Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented FrAngel on feat/frangel #7

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Implemented FrAngel on feat/frangel #7

merged 9 commits into from
Feb 6, 2025

Conversation

THinnerichs
Copy link
Member

Implemented FrAngel.

Still missing:

  • Angelic conditions
  • bound on how many fragments can added to the grammar
  • rest of the tests

@THinnerichs THinnerichs requested a review from ReubenJ January 30, 2025 16:40
@THinnerichs THinnerichs marked this pull request as draft January 30, 2025 16:40
@THinnerichs THinnerichs added the enhancement New feature or request label Jan 31, 2025
@THinnerichs THinnerichs changed the title [Draft] Implemented FrAngel on feat/frangel Implemented FrAngel on feat/frangel Jan 31, 2025
@THinnerichs THinnerichs marked this pull request as ready for review January 31, 2025 14:03
ReubenJ
ReubenJ requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ReubenJ ReubenJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Some housekeeping stuff, one extra test needed, and the formatter needs to be run on the new code.

THinnerichs and others added 2 commits February 5, 2025 16:02
@THinnerichs @ReubenJ
Update src/frangel/method.jl
a7966fd 
Co-authored-by: Reuben Gardos Reid <[email protected]>
@THinnerichs @ReubenJ
Update src/frangel/method.jl
65f6c85 
Co-authored-by: Reuben Gardos Reid <[email protected]>
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ReubenJ ReubenJ force-pushed the feat/frangel branch 2 times, most recently from 3f9c6e3 to d5100b7 Compare February 6, 2025 16:30
@ReubenJ ReubenJ self-requested a review February 6, 2025 16:46
@ReubenJ ReubenJ merged commit 47c9c0b into main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReubenJ ReubenJ ReubenJ approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@THinnerichs @codecov-commenter @ReubenJ