Python 3.12 support #104
Closed
Python 3.12 support #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…12 support will not work as long as we support 3.8, because numpy
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to add support to it through pdm, because poetry was not cooperating. I might not go with it, I don't like the venv management aspect very much, but I just might need to get used to. Otherwise, it might be better to just use setuptools
Turns out, the problem is numpy, that will not allow the library to support py3.8 and py3.12. I don't want to drop support for 3.8 yet, as it is still officially supported with security updates, and a lot of projects probably still use 3.8. But there is a change, I might lose users that want to use the latest updates for development.
Need to look more into this, there might be some special configuration for either poetry or pdm.