Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with ufs/dev #85

Merged
merged 132 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
132 commits
Select commit Hold shift + click to select a range
0a71797
Adds support for 3-moment rain/graupel/hail in NSSL microphysics sc…
MicroTed Apr 10, 2023
4e7ca4e
Added NSSL 3-moment variables to pre/post tracer arrays
MicroTed Apr 16, 2023
7956ada
Turn off unneeded print statement
MicroTed Apr 18, 2023
6ffe3a4
Merge commit 'b93cf5e07d10344ca9fb1398a11cec1d1d43c66b' into feature/…
MicroTed Apr 19, 2023
f020a3a
bug fix for rain evaporation due to inconsistent usage of air density…
gthompsnWRF Apr 27, 2023
c7f6d31
three small fixes: max ice size bin made smaller (since snow min size…
gthompsnWRF May 4, 2023
694040f
Merge branch 'BugFix_prv_rev' into small_fixes_GT
gthompsnWRF May 4, 2023
4c60a2f
Reorganize NRL ozone physics scheme into CCPP phases. Make scheme (me…
May 23, 2023
07f279d
Merge remote-tracking branch 'dswales/feature_reorg_ozphys' into HEAD
May 23, 2023
70b9d7e
RRTMGP changes for refactored NRL ozone physics.
May 25, 2023
6ff8689
Revert change to CI test from NCAR->UWM merge
May 25, 2023
32dfabe
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
Jun 8, 2023
856baa6
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
Jun 12, 2023
3682e47
Rollback changes to rain evaporation
Jun 14, 2023
9859339
Some changes
Jun 15, 2023
279e52b
Merge pull request #81 from AndersJensen-NOAA/rain_evap
grantfirl Jun 16, 2023
c3f9f71
Merge branch 'ufs/dev' into small_fixes_GT
grantfirl Jun 21, 2023
bb2af8c
optimized the code and decrease the stratosphere warm bias for mraero…
AnningCheng-NOAA Jun 29, 2023
0c01b39
bug fix the snow and graupel melting terms set to zero when sublimati…
gthompsnWRF Jul 5, 2023
2b6a7a4
Initiate SRW v3.0.0 SciDoc
mzhangw Jun 8, 2023
7ec1eb8
Some format and file size adjustments
mzhangw Jun 9, 2023
c901390
address some review comments
mzhangw Jun 15, 2023
57f72fb
Scidoc updates
mzhangw Jul 5, 2023
8cd2586
narrative description for previous update
mzhangw Jul 13, 2023
2a56d37
Host large images remotely
mkavulich Jun 30, 2023
a69c8a3
Merge branch 'ufs/dev' into strat_warm_bias_fix_cheng
grantfirl Jul 19, 2023
1a8f968
Merge branch 'ufs/dev' into small_fixes_GT
grantfirl Jul 19, 2023
9b69974
Merge pull request #88 from grantfirl/strat_warm_bias_fix_cheng
grantfirl Jul 24, 2023
9e35de1
Changes to logging and initialization of the CLM Lake Model.
SamuelTrahanNOAA Jul 24, 2023
03dbacc
Merge remote-tracking branch 'origin/ufs/dev' into tanya-fix-20230724
SamuelTrahanNOAA Jul 27, 2023
1fae3bc
some missing changes from last commit
SamuelTrahanNOAA Jul 27, 2023
180c43b
yet more changes missing in prior commits
SamuelTrahanNOAA Jul 27, 2023
ace56af
t_grnd(i) should be t_grnd(c)
SamuelTrahanNOAA Jul 28, 2023
c0c253f
fix another typo
SamuelTrahanNOAA Jul 28, 2023
452237b
Merge branch 'ufs/dev' into small_fixes_GT
grantfirl Jul 31, 2023
102d664
Some housekeeping: overwrite ccppsrw_doxyfile (no need to keep separa…
mkavulich Jul 31, 2023
0154a65
Remove old namelists, remove "develop" from names
mkavulich Aug 1, 2023
8f44755
Incorporate changes to FV3_HRRR namelist suggested by Tanya
mkavulich Aug 1, 2023
aaa02d8
Address Ligia/Weiwei's comments
mkavulich Aug 1, 2023
dbcd50f
Remove hard-coded path in doxyfile
mkavulich Aug 1, 2023
8188e26
Split ozone physics into time_vary and run components
Aug 1, 2023
39dccc8
Various formatting fixes, grammar and wording changes
mkavulich Aug 1, 2023
6b12f19
Less ambiguous wording regarding resolution
mkavulich Aug 1, 2023
6884732
*actually* fix ambiguous wording
mkavulich Aug 1, 2023
a583b26
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Aug 2, 2023
0bfac2a
Some cleanup. Now working
dustinswales Aug 2, 2023
724c20f
Weiwei's suggested changes
mkavulich Aug 3, 2023
bea77c8
More reorganization.
dustinswales Aug 10, 2023
816f607
More fixes from Weiwei
mkavulich Aug 14, 2023
9c342a5
Adding OpenACC statements to accelerate MYNN surface scheme performan…
timsliwinski-noaa Aug 15, 2023
af890d4
Merge pull request #69 from ufs-community/small_fixes_GT
grantfirl Aug 18, 2023
e2818ec
Merge branch 'ufs/dev' into srw300_scidoc_noimages
grantfirl Aug 18, 2023
725adbd
Merge remote-tracking branch 'upstream/ufs/dev' into tanya-fix-20230724
SamuelTrahanNOAA Aug 18, 2023
f12b69f
merge #91 (UFS-SRW v3.0.0 SciDoc updates)
SamuelTrahanNOAA Aug 18, 2023
6229818
add SPP support for G-F deep convection
JiliDong-NOAA Aug 21, 2023
5b94685
Merge pull request #92 from SamuelTrahanNOAA/tanya-fix-20230724
dustinswales Aug 22, 2023
6ce3da1
Merge branch 'ufs-community:ufs/dev' into feature/gf-spp
JiliDong-NOAA Aug 23, 2023
96f6002
minor change on explicitly delcaring data type
JiliDong-NOAA Aug 23, 2023
a03c684
Change 1D GS arrays from fixed size to allocated
MicroTed Aug 24, 2023
586b426
Merge branch 'ufs/dev' into ufsdev-nssl3m
MicroTed Aug 24, 2023
95e9ff2
Reworking how errmsg is treated in device code to remove some preproc…
timsliwinski-noaa Aug 24, 2023
36a313e
Removing preprocessor directives to re-enable print statements on GPU…
timsliwinski-noaa Aug 28, 2023
315d3cc
stop FV3_HRRR_c3 from crashing with gnu debug
SamuelTrahanNOAA Sep 6, 2023
fbb4b01
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
Sep 6, 2023
2c10492
Merge branch 'feature_reorg_ozphys' of https://github.com/dustinswale…
Sep 6, 2023
26ca9f9
Renamed file
Sep 6, 2023
7efb112
Merge pull request #98 from JiliDong-NOAA/feature/gf-spp
dustinswales Sep 8, 2023
770ad33
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
timsliwinski-noaa Sep 8, 2023
31a99de
Merge pull request #97 from timsliwinski-noaa/mynnsfc_openacc
grantfirl Sep 14, 2023
c0ec619
Added tendency limiter for mesosphere and horizontal wave number filt…
mdtoyNOAA Sep 19, 2023
ab84c01
"GF radar reflectivity, dust bug fix, and C3 updates"
haiqinli Sep 20, 2023
679ba73
Merge commit '31a99de0' into ufsdev-nssl3m
MicroTed Sep 20, 2023
5612a96
Fix race condition in GFS_phys_time_vary.fv3.F90 error detection
SamuelTrahanNOAA Sep 21, 2023
3ec61d3
detect empty errmsg in GFS_phys_time_vary.fv3.F90
SamuelTrahanNOAA Sep 21, 2023
7912a19
Initialize err variables in set_soilveg.f
SamuelTrahanNOAA Sep 21, 2023
7332c8e
initialize errmsg & errflg in noahmp_tables.f90
SamuelTrahanNOAA Sep 21, 2023
374996e
only read h2odata, ozdata and noahmp table when they are needed
SamuelTrahanNOAA Sep 22, 2023
5377c7c
passing nc back from microphysics
AnningCheng-NOAA Sep 22, 2023
f324aa5
Update variable name in mp_nssl.F90
MicroTed Sep 23, 2023
cfd8485
"to address the reviewer's comments"
haiqinli Sep 23, 2023
fda90e0
Update for NSSL 2/3-moment cloud physics
MicroTed Sep 23, 2023
0cb137e
Update NSSL documentation and references for 3-moment option
MicroTed Sep 24, 2023
9b9f553
module_mp_nssl_2mom.F90 : set ngs with constant
MicroTed Sep 24, 2023
f7efdce
Merge remote-tracking branch 'upstream/ufs/dev' into c3-pointer-fix
SamuelTrahanNOAA Sep 25, 2023
6ee6df6
module_mp_nssl_2mom.F90: removed unneeded lines
MicroTed Sep 25, 2023
671b5f0
Merge remote-tracking branch 'sam/bugfix/errmsgflg-race-condition' in…
SamuelTrahanNOAA Sep 25, 2023
dbd5f58
remove all constant 3D variables from clm lake
SamuelTrahanNOAA Sep 27, 2023
75ec623
calculate constants only once per i
SamuelTrahanNOAA Sep 27, 2023
7a8f693
"to address the reviewers' comments"
haiqinli Sep 27, 2023
a110a5b
Getting real close...
Sep 27, 2023
2886df9
Small cosmetic changes
Sep 27, 2023
17b057c
Housekeeping
Sep 27, 2023
17203fe
Housekeeping
Sep 27, 2023
3f6168b
More reorg.
Sep 27, 2023
d0a4bfd
Remove ozphysics modules. Now part of ty_ozphys
Sep 27, 2023
385ef4e
Some polishing. Merge 2006 ozone into module_ozphys
Sep 28, 2023
2e65765
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Sep 28, 2023
a55ce5e
z => dz
SamuelTrahanNOAA Sep 28, 2023
00d9060
Added documentation
dustinswales Sep 28, 2023
ab4d5f1
"correct the dimension of soil moisture for dust emission"
haiqinli Sep 29, 2023
e0a949d
Merge remote-tracking branch 'sam/clm-lake-fewer-variables' into c3-p…
SamuelTrahanNOAA Sep 29, 2023
609c90b
Merge remote-tracking branch 'haiqin/ufs/dev-radar' into c3-pointer-fix
SamuelTrahanNOAA Sep 29, 2023
dd91c3a
Merge pull request #102 from SamuelTrahanNOAA/c3-pointer-fix
grantfirl Oct 3, 2023
627a3bb
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
mdtoyNOAA Oct 6, 2023
e08ecd6
land surface updates for hr3
HelinWei-NOAA Oct 6, 2023
4f8004a
remove one printout from sfcsub.f and uncomment z0m composition in mo…
HelinWei-NOAA Oct 6, 2023
5bd6da7
Set initial values for some constants (just in case)
MicroTed Oct 11, 2023
5d38181
Merge remote-tracking branch 'upstream/ufs/dev' into ufsdev-nssl3m
MicroTed Oct 11, 2023
1b22397
Some more cleanup
dustinswales Oct 12, 2023
c65ee9e
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Oct 12, 2023
06bb2bc
Final cleanup
dustinswales Oct 12, 2023
89af3d8
Omission from previous commit
dustinswales Oct 12, 2023
9822325
Merge branch 'ufs/dev' into mrfd
grantfirl Oct 12, 2023
c6204e1
add dlw,dsw inst to cpllnd block
DeniseWorthen Oct 15, 2023
4704ecf
Merge branch 'hr3_land_upgrades' of https://github.com/HelinWei-NOAA/…
mdtoyNOAA Oct 16, 2023
69c9764
Merge pull request #109 from AnningCheng-NOAA/mrfd
grantfirl Oct 17, 2023
2f417bb
refine surface 2m t/q diagnostic method
HelinWei-NOAA Oct 17, 2023
19a3bb5
Merge branch 'ufs-community:ufs/dev' into feature/lndinst
DeniseWorthen Oct 17, 2023
df0a259
Merge branch 'hr3_land_upgrades' of https://github.com/HelinWei-NOAA/…
mdtoyNOAA Oct 17, 2023
ba68fe7
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
mdtoyNOAA Oct 19, 2023
085f608
Merge pull request #118 from DeniseWorthen/feature/lndinst
grantfirl Oct 20, 2023
55c5102
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
mdtoyNOAA Oct 20, 2023
00d3f26
Merge remote-tracking branch 'upstream/ufs/dev' into ufsdev-nssl3m
MicroTed Oct 23, 2023
1db5691
Merge pull request #111 from mdtoyNOAA/ufs/dev_meso_fix_new_ksmax
grantfirl Oct 23, 2023
03772d6
Merge remote-tracking branch 'upstream/ufs/dev' into ufsdev-nssl3m
MicroTed Oct 26, 2023
72bd9bc
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Oct 27, 2023
32cf7ba
Reverted standard_name change
dustinswales Oct 27, 2023
1abaff0
module_mp_nssl_2mom.F90: fix bug when nz > 128 where sedimentation d…
MicroTed Oct 29, 2023
3855dcc
Merge pull request #75 from dustinswales/feature_reorg_ozphys
dustinswales Nov 2, 2023
1042c01
Merge remote-tracking branch 'upstream/ufs/dev' into ufsdev-nssl3m
MicroTed Nov 2, 2023
e10030b
mp_nssl.F90: space formatting
MicroTed Nov 2, 2023
c751a5a
Merge pull request #110 from MicroTed/ufsdev-nssl3m
grantfirl Nov 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions physics/GFS_DCNV_generic_post.F90
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, qdiag3d, ras, &
index_of_temperature, index_of_x_wind, index_of_y_wind, ntqv, gq0, save_q, &
cnvw, cnvc, cnvw_phy_f3d, cnvc_phy_f3d, flag_for_dcnv_generic_tend, &
ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl, &
ntgnc, nthl, nthnc, nthv, ntgv, ntsigma, ntrac,clw, &
ntgnc, nthl, nthnc, nthv, ntgv, ntrz, ntgz, nthz, ntsigma, ntrac,clw, &
satmedmf, trans_trac, errmsg, errflg)


Expand Down Expand Up @@ -44,8 +44,9 @@ subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, qdiag3d, ras, &
real(kind=kind_phys), dimension(:,:,:), intent(inout) :: dtend
integer, intent(in) :: dtidx(:,:), index_of_process_dcnv, index_of_temperature, &
index_of_x_wind, index_of_y_wind, ntqv
integer, intent(in) :: ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl, &
ntgnc, nthl, nthnc, nthv, ntgv, ntsigma, ntrac
integer, intent(in) :: ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl, &
ntgnc, nthl, nthnc, nthv, ntgv, ntrz, ntgz, nthz, &
ntsigma, ntrac
real(kind=kind_phys), dimension(:,:,:), intent(in) :: clw


Expand Down Expand Up @@ -112,6 +113,7 @@ subroutine GFS_DCNV_generic_post_run (im, levs, lssav, ldiag3d, qdiag3d, ras, &
n /= ntrw .and. n /= ntsw .and. n /= ntrnc .and. &
n /= ntsnc .and. n /= ntgl .and. n /= ntgnc .and. &
n /= nthl .and. n /= nthnc .and. n /= nthv .and. &
n /= ntrz .and. n /= ntgz .and. n /= nthz .and. &
n /= ntgv .and. n /= ntsigma) then
tracers = tracers + 1
idtend = dtidx(100+n,index_of_process_dcnv)
Expand Down
21 changes: 21 additions & 0 deletions physics/GFS_DCNV_generic_post.meta
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,27 @@
dimensions = ()
type = integer
intent = in
[ntrz]
standard_name = index_of_reflectivity_of_rain_in_tracer_concentration_array
long_name = tracer index for rain reflectivity
units = index
dimensions = ()
type = integer
intent = in
[ntgz]
standard_name = index_of_reflectivity_of_graupel_in_tracer_concentration_array
long_name = tracer index for graupel reflectivity
units = index
dimensions = ()
type = integer
intent = in
[nthz]
standard_name = index_of_reflectivity_of_hail_in_tracer_concentration_array
long_name = tracer index for hail reflectivity
units = index
dimensions = ()
type = integer
intent = in
[clw]
standard_name = convective_transportable_tracers
long_name = array to contain cloud water and other convective trans. tracers
Expand Down
7 changes: 5 additions & 2 deletions physics/GFS_DCNV_generic_pre.F90
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ subroutine GFS_DCNV_generic_pre_run (im, levs, ldiag3d, qdiag3d, do_cnvgwd, cplc
gu0, gv0, gt0, gq0, nsamftrac, ntqv, &
save_u, save_v, save_t, save_q, clw, &
ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl, &
ntgnc, nthl, nthnc, nthv, ntgv,ntsigma, &
ntgnc, nthl, nthnc, nthv, ntgv, &
ntrz, ntgz, nthz, ntsigma, &
cscnv, satmedmf, trans_trac, ras, ntrac, &
dtidx, index_of_process_dcnv, errmsg, errflg)

Expand All @@ -22,7 +23,8 @@ subroutine GFS_DCNV_generic_pre_run (im, levs, ldiag3d, qdiag3d, do_cnvgwd, cplc
implicit none

integer, intent(in) :: im, levs, nsamftrac, ntqv, index_of_process_dcnv, dtidx(:,:), &
ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl,ntrac,ntgnc,nthl,nthnc,nthv,ntgv,ntsigma
ntcw,ntiw,ntclamt,ntrw,ntsw,ntrnc,ntsnc,ntgl,ntrac,ntgnc,nthl,nthnc,nthv,ntgv, &
ntrz, ntgz, nthz, ntsigma
logical, intent(in) :: ldiag3d, qdiag3d, do_cnvgwd, cplchm
real(kind=kind_phys), dimension(:,:), intent(in) :: gu0
real(kind=kind_phys), dimension(:,:), intent(in) :: gv0
Expand Down Expand Up @@ -68,6 +70,7 @@ subroutine GFS_DCNV_generic_pre_run (im, levs, ldiag3d, qdiag3d, do_cnvgwd, cplc
n /= ntrw .and. n /= ntsw .and. n /= ntrnc .and. &
n /= ntsnc .and. n /= ntgl .and. n /= ntgnc .and. &
n /= nthl .and. n /= nthnc .and. n /= nthv .and. &
n /= ntrz .and. n /= ntgz .and. n /= nthz .and. &
n /= ntgv .and. n/= ntsigma) then
tracers = tracers + 1
if(dtidx(100+n,index_of_process_dcnv)>0) then
Expand Down
21 changes: 21 additions & 0 deletions physics/GFS_DCNV_generic_pre.meta
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,27 @@
dimensions = ()
type = integer
intent = in
[ntrz]
standard_name = index_of_reflectivity_of_rain_in_tracer_concentration_array
long_name = tracer index for rain reflectivity
units = index
dimensions = ()
type = integer
intent = in
[ntgz]
standard_name = index_of_reflectivity_of_graupel_in_tracer_concentration_array
long_name = tracer index for graupel reflectivity
units = index
dimensions = ()
type = integer
intent = in
[nthz]
standard_name = index_of_reflectivity_of_hail_in_tracer_concentration_array
long_name = tracer index for hail reflectivity
units = index
dimensions = ()
type = integer
intent = in
[clw]
standard_name = convective_transportable_tracers
long_name = array to contain cloud water and other convective trans. tracers
Expand Down
29 changes: 22 additions & 7 deletions physics/GFS_PBL_generic_post.F90
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ module GFS_PBL_generic_post
!!
subroutine GFS_PBL_generic_post_run (im, levs, nvdiff, ntrac, &
ntqv, ntcw, ntiw, ntrw, ntsw, ntlnc, ntinc, ntrnc, ntsnc, ntgnc, ntwa, ntia, ntgl, ntoz, ntke, ntkev,nqrimef, &
trans_aero, ntchs, ntchm, ntccn, nthl, nthnc, ntgv, nthv, &
trans_aero, ntchs, ntchm, ntccn, nthl, nthnc, ntgv, nthv, ntrz, ntgz, nthz, &
imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_wsm6, imp_physics_zhao_carr, imp_physics_mg, &
imp_physics_fer_hires, imp_physics_nssl, nssl_ccn_on, ltaerosol, mraerosol, nssl_hail_on, &
imp_physics_fer_hires, imp_physics_nssl, nssl_ccn_on, ltaerosol, mraerosol, nssl_hail_on, nssl_3moment, &
cplflx, cplaqm, cplchm, lssav, flag_for_pbl_generic_tend, ldiag3d, lsidea, hybedmf, do_shoc, satmedmf, &
shinhong, do_ysu, dvdftra, dusfc1, dvsfc1, dtsfc1, dqsfc1, dtf, dudt, dvdt, dtdt, htrsw, htrlw, xmu, &
dqdt, dusfc_cpl, dvsfc_cpl, dtsfc_cpl, dtend, dtidx, index_of_temperature, index_of_x_wind, index_of_y_wind, &
Expand All @@ -30,12 +30,12 @@ subroutine GFS_PBL_generic_post_run (im, levs, nvdiff, ntrac,
integer, parameter :: kp = kind_phys
integer, intent(in) :: im, levs, nvdiff, ntrac, ntchs, ntchm, kdt
integer, intent(in) :: ntqv, ntcw, ntiw, ntrw, ntsw, ntlnc, ntinc, ntrnc, ntsnc, ntgnc, ntwa, ntia, ntgl, ntoz, ntke, ntkev, nqrimef
integer, intent(in) :: ntccn, nthl, nthnc, ntgv, nthv
integer, intent(in) :: ntccn, nthl, nthnc, ntgv, nthv, ntrz, ntgz, nthz
logical, intent(in) :: trans_aero
integer, intent(in) :: imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_wsm6
integer, intent(in) :: imp_physics_zhao_carr, imp_physics_mg, imp_physics_fer_hires
integer, intent(in) :: imp_physics_nssl
logical, intent(in) :: nssl_ccn_on, nssl_hail_on
logical, intent(in) :: nssl_ccn_on, nssl_hail_on, nssl_3moment
logical, intent(in) :: ltaerosol, cplflx, cplaqm, cplchm, lssav, ldiag3d, lsidea, use_med_flux, mraerosol
logical, intent(in) :: hybedmf, do_shoc, satmedmf, shinhong, do_ysu

Expand Down Expand Up @@ -270,8 +270,16 @@ subroutine GFS_PBL_generic_post_run (im, levs, nvdiff, ntrac,
dqdt(i,k,ntgv) = dvdftra(i,k,14)
dqdt(i,k,nthv) = dvdftra(i,k,15)
dqdt(i,k,ntoz) = dvdftra(i,k,16)
n = 16
IF ( nssl_ccn_on ) THEN
dqdt(i,k,ntccn) = dvdftra(i,k,17)
dqdt(i,k,ntccn) = dvdftra(i,k,n+1)
n = n+1
ENDIF
IF ( nssl_3moment ) THEN
dqdt(i,k,ntrz) = dvdftra(i,k,n+1)
dqdt(i,k,ntgz) = dvdftra(i,k,n+2)
dqdt(i,k,nthz) = dvdftra(i,k,n+3)
n = n+3
ENDIF
enddo
enddo
Expand All @@ -292,9 +300,16 @@ subroutine GFS_PBL_generic_post_run (im, levs, nvdiff, ntrac,
dqdt(i,k,ntsnc) = dvdftra(i,k,10)
dqdt(i,k,ntgnc) = dvdftra(i,k,11)
dqdt(i,k,ntgv) = dvdftra(i,k,12)
dqdt(i,k,ntoz) = dvdftra(i,k,13)
dqdt(i,k,ntoz) = dvdftra(i,k,13)
n = 13
IF ( nssl_ccn_on ) THEN
dqdt(i,k,ntccn) = dvdftra(i,k,14)
dqdt(i,k,ntccn) = dvdftra(i,k,n+1)
n = n+1
ENDIF
IF ( nssl_3moment ) THEN
dqdt(i,k,ntrz) = dvdftra(i,k,n+1)
dqdt(i,k,ntgz) = dvdftra(i,k,n+2)
n = n+2
ENDIF
enddo
enddo
Expand Down
28 changes: 28 additions & 0 deletions physics/GFS_PBL_generic_post.meta
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,27 @@
dimensions = ()
type = integer
intent = in
[ntrz]
standard_name = index_of_reflectivity_of_rain_in_tracer_concentration_array
long_name = tracer index for rain reflectivity
units = index
dimensions = ()
type = integer
intent = in
[ntgz]
standard_name = index_of_reflectivity_of_graupel_in_tracer_concentration_array
long_name = tracer index for graupel reflectivity
units = index
dimensions = ()
type = integer
intent = in
[nthz]
standard_name = index_of_reflectivity_of_hail_in_tracer_concentration_array
long_name = tracer index for hail reflectivity
units = index
dimensions = ()
type = integer
intent = in
[imp_physics]
standard_name = control_for_microphysics_scheme
long_name = choice of microphysics scheme
Expand Down Expand Up @@ -295,6 +316,13 @@
dimensions = ()
type = logical
intent = in
[nssl_3moment]
standard_name = nssl_3moment
long_name = 3-moment activation flag in NSSL microphysics scheme
units = flag
dimensions = ()
type = logical
intent = in
[cplflx]
standard_name = flag_for_surface_flux_coupling
long_name = flag controlling cplflx collection (default off)
Expand Down
49 changes: 32 additions & 17 deletions physics/GFS_PBL_generic_pre.F90
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ module GFS_PBL_generic_pre
subroutine GFS_PBL_generic_pre_run (im, levs, nvdiff, ntrac, rtg_ozone_index, &
ntqv, ntcw, ntiw, ntrw, ntsw, ntlnc, ntinc, ntrnc, ntsnc, ntgnc, &
ntwa, ntia, ntgl, ntoz, ntke, ntkev, nqrimef, trans_aero, ntchs, ntchm, &
ntccn, nthl, nthnc, ntgv, nthv, &
ntccn, nthl, nthnc, ntgv, nthv, ntrz, ntgz, nthz, &
imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_wsm6, &
imp_physics_zhao_carr, imp_physics_mg, imp_physics_fer_hires, imp_physics_nssl, &
ltaerosol, mraerosol, nssl_ccn_on, nssl_hail_on, &
ltaerosol, mraerosol, nssl_ccn_on, nssl_hail_on, nssl_3moment, &
hybedmf, do_shoc, satmedmf, qgrs, vdftra, save_u, save_v, save_t, save_q, &
flag_for_pbl_generic_tend, ldiag3d, qdiag3d, lssav, ugrs, vgrs, tgrs, errmsg, errflg)

Expand All @@ -29,13 +29,13 @@ subroutine GFS_PBL_generic_pre_run (im, levs, nvdiff, ntrac, rtg_ozone_index,
integer, intent(in) :: im, levs, nvdiff, ntrac
integer, intent(in) :: ntqv, ntcw, ntiw, ntrw, ntsw, ntlnc, ntinc, ntrnc, ntsnc, ntgnc
integer, intent(in) :: ntwa, ntia, ntgl, ntoz, ntke, ntkev, nqrimef,ntchs, ntchm
integer, intent(in) :: ntccn, nthl, nthnc, ntgv, nthv
integer, intent(in) :: ntccn, nthl, nthnc, ntgv, nthv, ntrz, ntgz, nthz
logical, intent(in) :: trans_aero, ldiag3d, qdiag3d, lssav
integer, intent(in) :: imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_wsm6
integer, intent(in) :: imp_physics_zhao_carr, imp_physics_mg, imp_physics_fer_hires
logical, intent(in) :: ltaerosol, hybedmf, do_shoc, satmedmf, flag_for_pbl_generic_tend, mraerosol
integer, intent(in) :: imp_physics_nssl
logical, intent(in) :: nssl_hail_on, nssl_ccn_on
logical, intent(in) :: nssl_hail_on, nssl_ccn_on, nssl_3moment

real(kind=kind_phys), dimension(:,:,:), intent(in) :: qgrs
real(kind=kind_phys), dimension(:,:), intent(in) :: ugrs, vgrs, tgrs
Expand Down Expand Up @@ -215,15 +215,23 @@ subroutine GFS_PBL_generic_pre_run (im, levs, nvdiff, ntrac, rtg_ozone_index,
vdftra(i,k,7) = qgrs(i,k,nthl)
vdftra(i,k,8) = qgrs(i,k,ntlnc)
vdftra(i,k,9) = qgrs(i,k,ntinc)
vdftra(i,k,10) = qgrs(i,k,ntrnc)
vdftra(i,k,11) = qgrs(i,k,ntsnc)
vdftra(i,k,12) = qgrs(i,k,ntgnc)
vdftra(i,k,13) = qgrs(i,k,nthnc)
vdftra(i,k,14) = qgrs(i,k,ntgv)
vdftra(i,k,15) = qgrs(i,k,nthv)
vdftra(i,k,16) = qgrs(i,k,ntoz)
vdftra(i,k,10) = qgrs(i,k,ntrnc)
vdftra(i,k,11) = qgrs(i,k,ntsnc)
vdftra(i,k,12) = qgrs(i,k,ntgnc)
vdftra(i,k,13) = qgrs(i,k,nthnc)
vdftra(i,k,14) = qgrs(i,k,ntgv)
vdftra(i,k,15) = qgrs(i,k,nthv)
vdftra(i,k,16) = qgrs(i,k,ntoz)
n = 16
IF ( nssl_ccn_on ) THEN
vdftra(i,k,17) = qgrs(i,k,ntccn)
vdftra(i,k,n+1) = qgrs(i,k,ntccn)
n = n+1
ENDIF
IF ( nssl_3moment ) THEN
vdftra(i,k,n+1) = qgrs(i,k,ntrz)
vdftra(i,k,n+2) = qgrs(i,k,ntgz)
vdftra(i,k,n+3) = qgrs(i,k,nthz)
n = n+3
ENDIF
enddo
enddo
Expand All @@ -241,12 +249,19 @@ subroutine GFS_PBL_generic_pre_run (im, levs, nvdiff, ntrac, rtg_ozone_index,
vdftra(i,k,7) = qgrs(i,k,ntlnc)
vdftra(i,k,8) = qgrs(i,k,ntinc)
vdftra(i,k,9) = qgrs(i,k,ntrnc)
vdftra(i,k,10) = qgrs(i,k,ntsnc)
vdftra(i,k,11) = qgrs(i,k,ntgnc)
vdftra(i,k,12) = qgrs(i,k,ntgv)
vdftra(i,k,13) = qgrs(i,k,ntoz)
vdftra(i,k,10) = qgrs(i,k,ntsnc)
vdftra(i,k,11) = qgrs(i,k,ntgnc)
vdftra(i,k,12) = qgrs(i,k,ntgv)
vdftra(i,k,13) = qgrs(i,k,ntoz)
n = 13
IF ( nssl_ccn_on ) THEN
vdftra(i,k,14) = qgrs(i,k,ntccn)
vdftra(i,k,n+1) = qgrs(i,k,ntccn)
n = n+1
ENDIF
IF ( nssl_3moment ) THEN
vdftra(i,k,n+1) = qgrs(i,k,ntrz)
vdftra(i,k,n+2) = qgrs(i,k,ntgz)
n = n+2
ENDIF
enddo
enddo
Expand Down
28 changes: 28 additions & 0 deletions physics/GFS_PBL_generic_pre.meta
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,27 @@
dimensions = ()
type = integer
intent = in
[ntrz]
standard_name = index_of_reflectivity_of_rain_in_tracer_concentration_array
long_name = tracer index for rain reflectivity
units = index
dimensions = ()
type = integer
intent = in
[ntgz]
standard_name = index_of_reflectivity_of_graupel_in_tracer_concentration_array
long_name = tracer index for graupel reflectivity
units = index
dimensions = ()
type = integer
intent = in
[nthz]
standard_name = index_of_reflectivity_of_hail_in_tracer_concentration_array
long_name = tracer index for hail reflectivity
units = index
dimensions = ()
type = integer
intent = in
[imp_physics]
standard_name = control_for_microphysics_scheme
long_name = choice of microphysics scheme
Expand Down Expand Up @@ -301,6 +322,13 @@
dimensions = ()
type = logical
intent = in
[nssl_3moment]
standard_name = nssl_3moment
long_name = 3-moment activation flag in NSSL microphysics scheme
units = flag
dimensions = ()
type = logical
intent = in
[hybedmf]
standard_name = flag_for_hybrid_edmf_pbl_scheme
long_name = flag for hybrid edmf pbl scheme (moninedmf)
Expand Down
Loading
Loading