Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zzre: Add line intersections and refactor #299

Merged
merged 6 commits into from
Feb 3, 2024
Merged

Conversation

Helco
Copy link
Owner

@Helco Helco commented Feb 3, 2024

For the upcoming actor lighting (also footsteps, some spell fx) we need line intersections. As we commonly have to ignore invisible textures for the visual effects we cannot just use Cast as this only ever returns the nearest intersection. However I will use this opportunity to apply some much needed refactoring in the world of zzre math.

The goal for this PR would be something like:

  • Add line intersections
  • Move every actual Intersection math into a central IntersectionQueries.cs file
  • Move every actual (primitive) Cast math into Ray
  • Move every convenience interface methods into IntersectionQueries.Mixin.cs file
  • Generalize AtomicSlowCollider and GeometrySlowCollider like was done with TreeCollider
  • Add line intersection tests to WorldViewer
  • Investigate why Plane and Box are not readonly

I should also rebase the actor commit out of this PR before merging

@Helco Helco self-assigned this Feb 3, 2024
@Helco Helco changed the title Add line intersections Add line intersections and refactor Feb 3, 2024
@Helco Helco force-pushed the line-intersections branch from cc92929 to 7bc16cc Compare February 3, 2024 16:26
@Helco Helco marked this pull request as ready for review February 3, 2024 16:26
@Helco Helco changed the title Add line intersections and refactor zzre: Add line intersections and refactor Feb 3, 2024
@Helco Helco merged commit 73d64d0 into master Feb 3, 2024
2 checks passed
@Helco Helco deleted the line-intersections branch February 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant