Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix linker error #83

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented Jun 10, 2022

Trashes a8 register by loading the target function, then does a call using that register.

As described in https://sourceware.org/binutils/docs-2.32/as/Xtensa-Call-Relaxation.html

No idea if this works, just for reference.

To properly fix this error, please recompile that rtc-board.c file with the -mlongcalls option!

See #82

Completely untested. Might crash and burn.

@Heltec-Aaron-Lee Heltec-Aaron-Lee marked this pull request as ready for review July 14, 2022 06:26
@Heltec-Aaron-Lee Heltec-Aaron-Lee merged commit 91c609f into HelTecAutomation:master Jul 14, 2022
@maxgerhardt
Copy link
Contributor Author

Noooo, people reported it still doesn't work after these corrections in #82!! Was this tested on hardware before merge?

@maxgerhardt
Copy link
Contributor Author

Please recompile the library with -mlongcalls properly from source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants