Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #134

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Dev #134

merged 7 commits into from
Aug 5, 2024

Conversation

lubynets
Copy link
Contributor

@lubynets lubynets commented Aug 5, 2024

  1. Titles (descriptions) of default fields are made more precise and informative.
  2. Added a title to Branch (similarly to that of Field) - for detailed description of branch.
  3. SetMass() and SetCharge() for Particle are made more safe - user can call them only if explicitly unlocks this possibility. Otherwise one should call SetPid(), and charge with mass will be set automatically.
  4. AnalysisTreeDiff.patch file (see PR #127) is set to be update in each build-install action, even if it is empty (to avoid misleading remnant AnalysisTreeDiff.patch file from the previous building).

@lubynets
Copy link
Contributor Author

lubynets commented Aug 5, 2024

Note: for some reasons when building source code at container machine (github actions) the code crashes at git diff - when at usual machine one would obtain just an empty response. This is fixed in the last commit "fix error..."

@lubynets lubynets merged commit 6df77c1 into HeavyIonAnalysis:master Aug 5, 2024
4 checks passed
@lubynets lubynets deleted the dev branch August 5, 2024 15:50
lubynets added a commit to lubynets/AnalysisTree that referenced this pull request Jan 15, 2025
lubynets added a commit that referenced this pull request Jan 15, 2025
* enable SimpleCut title reading

* bugfix of versioning machinery: create diff file of AT, not dependent package

* add .vscode to .gitignore

* fix examples/WritingMacro.C according to PR #134 #134

---------

Co-authored-by: Oleksii Lubynets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant