Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stac-fastapi.core to v3.0.0a0 #23

Merged
merged 7 commits into from
May 18, 2024
Merged

Update stac-fastapi.core to v3.0.0a0 #23

merged 7 commits into from
May 18, 2024

Conversation

jonhealy1
Copy link
Contributor

@jonhealy1 jonhealy1 commented May 11, 2024

Related Issue(s):

Description:

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 marked this pull request as ready for review May 11, 2024 16:50
@pedro-cf pedro-cf self-requested a review May 11, 2024 23:35

Returns:
str: The parsed and formatted date string in the format 'YYYY-MM-DDTHH:MM:SS.ssssssZ'.
str: The normalized datetime string in the format "YYYY-MM-DDTHH:MM:SSZ".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is %Y-%m-%dT%H:%M:%SZ the default accepted format? I think microseconds are important to include too. Guessing it's enforced by stac-fastapi.core or stac-fastapi.api ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pedro-cf I meant to look into microseconds and then I forgot ...

@pedro-cf
Copy link
Collaborator

Think this is good to close @jonhealy1 ?

@jonhealy1 jonhealy1 merged commit ac940c2 into main May 18, 2024
4 checks passed
@jonhealy1 jonhealy1 deleted the core-3.0.0a0 branch May 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants