Remove unused code paths

HarvestProfit · Dec 4, 2017 · fa1dce8 · fa1dce8
1 parent eb90761
commit fa1dce8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/UnitsHelper.js b/src/UnitsHelper.js
@@ -88,18 +88,14 @@ export default class UnitsHelper {
           lbsPerGallon,
         );
         const finalCalc = finalUnit.to(productUnit).toNumber();
-        if (finalCalc > 0) {
-          totalPerUnit = product.price * finalCalc;
-        }
+        totalPerUnit = product.price * finalCalc;
       } else {
         // If all else fails, try to convert
         const lineItemInProductUnits = Math
           .unit(1, lineItemUnit)
           .to(productUnit)
           .toNumber();
-        if (lineItemInProductUnits > 0) {
-          totalPerUnit = product.price * lineItemInProductUnits;
-        }
+        totalPerUnit = product.price * lineItemInProductUnits;
       }
     } catch (error) {
       totalPerUnit = product.price;

diff --git a/test/UnitsHelper.test.js b/test/UnitsHelper.test.js
@@ -79,6 +79,19 @@ describe('UnitsHelper', () => {
     expect(gallonsToTons.toNumber()).toBeCloseTo(1);
   });
 
+  it('should convert liquids to solids based on the American assumption', () => {
+    const gallons = 8000;
+    const gallonsPerPound = 4;
+    const poundsPerGallon = 1 / gallonsPerPound;
+    const gallonsToTons = UnitsHelper.liquidToSolid(
+      gallons,
+      'gallons',
+      'tons',
+      poundsPerGallon,
+    );
+    expect(gallonsToTons.toNumber()).toBeCloseTo(1);
+  });
+
   describe('isLiquid', () => {
     it('should correctly recognize a liquid product', () => {
       const liquidProduct = liquidProductInTons;