Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python script to check the validity of a given IP address #1368

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Python script to check the validity of a given IP address #1368

wants to merge 6 commits into from

Conversation

Yashesvinee
Copy link

Description

Added Python script to check the validity of a given IP address and hostname.

Fixes #1367

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Apr 6, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ClasherKasten
ClasherKasten reviewed Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@ClasherKasten ClasherKasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for this one little technical correction (i think that is like that, but eventually I'm wrong, then sorry) this looks good. Thanks for the contribution.

Python/IP-Hostname_Validator/README.md Outdated
Comment on lines 2 to 5
### Libraries used:
- ipaddress - Provides functions to create, manipulate and operate in IPv4 and IPv6 addresses and networks.
- sys - Used to provide access to variables maintained by the interpreter.
- socket - Provides functions and objects to build network applications for clients and servers. It helps access the BSD Socket interface.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically i think these aren't libraries, but instead modules of the standard library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClasherKasten ClasherKasten ClasherKasten left review comments

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@iamakkkhil iamakkkhil Awaiting requested review from iamakkkhil

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[script request]: Python script to check the validity of a given IP address
2 participants
@Yashesvinee @ClasherKasten