Even better testing #129
Merged
Even better testing #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbor-client/src/lib.rs
Outdated
Comment on lines
440
to
448
| #[cfg(feature = "disable-tor")] | ||
| let config = fedimint_api_client::api::net::Connector::Tcp | ||
| .download_from_invite_code(&invite_code) | ||
| .await | ||
| .map_err(|e| { | ||
| error!("Could not download federation info: {e}"); | ||
| e | ||
| })?; | ||
| #[cfg(not(feature = "disable-tor"))] |
There was a problem hiding this comment.
can we have these include the debug_assertions like I did in the other one, that way for a production release we can't accidentally disable tor
harbor-client/src/fedimint_client.rs
Outdated
Comment on lines
105
to
114
| #[cfg(feature = "disable-tor")] | ||
| let config = fedimint_api_client::api::net::Connector::Tcp | ||
| .download_from_invite_code(&invite_code) | ||
| .await | ||
| .map_err(|e| { | ||
| error!("Could not download federation info: {e}"); | ||
| e | ||
| })?; | ||
| #[cfg(not(feature = "disable-tor"))] | ||
| let config = fedimint_api_client::api::net::Connector::Tor |
benthecarman
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #128
also added an auto unlock if there's a password supplied