Add debug ring support to normal ExecuteIndirect #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
from
3db7216 to
daef18b
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
3 times, most recently
from
3bbce3a to
e456907
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
from
e456907 to
a420562
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
from
a420562 to
0aed869
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
2 times, most recently
from
17aecf8 to
b542c17
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
3 times, most recently
from
acb85f0 to
33c0e08
Compare
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
4 times, most recently
from
ffcee2b to
c1534e6
Compare
When debugging hangs, intention is that we can dump all execute indirect commands to debug ring. Some crashes are caused by broken indirect buffers. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
When using breadcrumbs_trace_indirect, allow generic indirect commands to go through debugger as well. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
debug-ring-indirect
branch
from
c1534e6 to
c208c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging execute indirect faults, we need to know the input arguments to have any hope chasing things down.