Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design new slack sign up #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Design new slack sign up #2

wants to merge 2 commits into from

Conversation

devonsoto
Copy link

Description

The beginning design for the slack signup page.

Related Issues

n/a

Some questions

  1. Did you read the contributing guidelines?
    There aren't any but si.

Additional Notes

Do you want to add anything else? We ❤️ to hear your opinions!

Waiting on background image design and img for field from slack.hack.org.

Share how this made you feel

Copy link
Member

@casassg casassg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small review of current status

<meta name="author" content="HackCU"/>
<meta name="theme-color" content="#315B7F">
<meta name="copyright" content="HackCU"/>
<meta name="application-name" content="Local Hack Day 2018"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to change all the above tags

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


<!-- CSS -->
<link rel="stylesheet" href="css/fall.css">
<link rel="stylesheet" href="css/style.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ?_={{ site.time | date: '%s' }} for cache busting

Reference: http://www.adopsinsider.com/ad-ops-basics/what-is-a-cache-buster-and-how-does-it-work/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


<!-- JS -->
<script src='https://cdnjs.cloudflare.com/ajax/libs/gsap/1.20.3/TweenMax.min.js'></script>
<script src="js/fall.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, cache busting.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated

1. Remove background
1. Resize the image to `600 x 400 px` centering
3. Archive the original `.png` file in the corresponding `originals/` folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No logos on this page most probably, you can delete this lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1 @@
# Contributing Guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy from other repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna keep so we know that we need contributing guidelines still or to update them

<!-- Libs and Plugins CSS -->
<!-- <link rel="stylesheet" href="inc/bootstrap/css/bootstrap.min.css">
<link rel="stylesheet" href="inc/font-awesome/css/font-awesome.min.css"> -->
<!-- Font Icons -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to use Biko (official HackCU font). See files: https://github.com/HackCU/HackCU/tree/master/assets/fonts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants