-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design new slack sign up #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small review of current status
_layouts/base.html
Outdated
<meta name="author" content="HackCU"/> | ||
<meta name="theme-color" content="#315B7F"> | ||
<meta name="copyright" content="HackCU"/> | ||
<meta name="application-name" content="Local Hack Day 2018"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to change all the above tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
_layouts/base.html
Outdated
|
||
<!-- CSS --> | ||
<link rel="stylesheet" href="css/fall.css"> | ||
<link rel="stylesheet" href="css/style.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ?_={{ site.time | date: '%s' }}
for cache busting
Reference: http://www.adopsinsider.com/ad-ops-basics/what-is-a-cache-buster-and-how-does-it-work/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
_layouts/base.html
Outdated
|
||
<!-- JS --> | ||
<script src='https://cdnjs.cloudflare.com/ajax/libs/gsap/1.20.3/TweenMax.min.js'></script> | ||
<script src="js/fall.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, cache busting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
README.md
Outdated
|
||
1. Remove background | ||
1. Resize the image to `600 x 400 px` centering | ||
3. Archive the original `.png` file in the corresponding `originals/` folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No logos on this page most probably, you can delete this lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -0,0 +1 @@ | |||
# Contributing Guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy from other repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna keep so we know that we need contributing guidelines still or to update them
<!-- Libs and Plugins CSS --> | ||
<!-- <link rel="stylesheet" href="inc/bootstrap/css/bootstrap.min.css"> | ||
<link rel="stylesheet" href="inc/font-awesome/css/font-awesome.min.css"> --> | ||
<!-- Font Icons --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to use Biko (official HackCU font). See files: https://github.com/HackCU/HackCU/tree/master/assets/fonts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
The beginning design for the slack signup page.
Related Issues
n/a
Some questions
There aren't any but si.
Additional Notes
Do you want to add anything else? We ❤️ to hear your opinions!
Waiting on background image design and img for field from slack.hack.org.
Share how this made you feel