Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 MCnet addition #1507

Merged
merged 4 commits into from
Feb 9, 2024
Merged

2024 MCnet addition #1507

merged 4 commits into from
Feb 9, 2024

Conversation

20DM
Copy link
Contributor

@20DM 20DM commented Feb 8, 2024

Adding another MCnet project for 2024.

* Familiarise with the YODA library;
* Familiarise with the YODA unit test system, including current CI scripts;
* Hook up existing Familiarise with `gcov` for producing coverage report;
* Familiarise and its visualization tools
Copy link
Contributor

@vvolkl vvolkl Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Familiarise and its visualization tools
* Familiarise with its visualization tools

Do you mean existing visualization tools in YODA or that the student should pick some visualization library to do the coverage reports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter! Sorry, I should have read this more carefully last night before committing. I removed the rogue bullet points, so hopefully it makes sense now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now it's very clear, I think.

Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thanks!

@hegner hegner merged commit adb08fb into HSF:main Feb 9, 2024
1 check passed
@vvolkl
Copy link
Contributor

vvolkl commented Feb 9, 2024

@20DM I forgot one thing: Is there someone who could act as co-mentor for this project (even if it is just to fill in during your holidays, it's good practice)?

@20DM
Copy link
Contributor Author

20DM commented Feb 9, 2024

@vvolkl Yeah, there's a couple of people that come to mind - I'm sure between Andy and me we'll be able to work something out if necessary. Did you need me to specify someone now already?

@vvolkl
Copy link
Contributor

vvolkl commented Feb 9, 2024

Thanks, If it's ok, I'll add Andy as a placeholder right now, you can then change this anytime.

@20DM
Copy link
Contributor Author

20DM commented Feb 9, 2024

Fine by me - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants