添加 unlisted-versions-of-minecraft #3247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burningtnt
suggested changes
Jan 27, 2025
| @@ -77,7 +77,8 @@ public BMCLAPIDownloadProvider(String apiRoot) { | |||
| pair("https://meta.fabricmc.net", apiRoot + "/fabric-meta"), | |||
| pair("https://maven.fabricmc.net", apiRoot + "/maven"), | |||
| pair("https://authlib-injector.yushi.moe", apiRoot + "/mirrors/authlib-injector"), | |||
| pair("https://repo1.maven.org/maven2", "https://mirrors.cloud.tencent.com/nexus/repository/maven-public") | |||
| pair("https://repo1.maven.org/maven2", "https://mirrors.cloud.tencent.com/nexus/repository/maven-public"), | |||
| pair("https://zkitefly.github.io/unlisted-versions-of-minecraft", "https://vip.123pan.cn/1821946486/unlisted-versions-of-minecraft") | |||
There was a problem hiding this comment.
应该够用的，不行就去掉得了（
等下做一个 version_manifest 构建时拉取
There was a problem hiding this comment.
你可以在这里将镜像更改为 hmcl://assets/unlisted-version-of-mc，并在 HttpRequest 中添加对 hmcl schema 的实现
| @@ -127,6 +127,7 @@ public enum Type { | |||
| UNCATEGORIZED, | |||
| RELEASE, | |||
| SNAPSHOT, | |||
| OLD | |||
| OLD, | |||
| PENDING | |||
There was a problem hiding this comment.
使用 PENDING 类型的意义是什么？在其他地方代码和 SNAPSHOT 类型似乎完全是一致的？还是只是我没发现
There was a problem hiding this comment.
There was a problem hiding this comment.
我的意思是，你同时在 ReleaseType 和 RemoteVersion.Type 中声明了新的类型 PENDING，但这一类型和 SNAPSHOT 类型完全一致。这么做的意义是什么？
HMCLCore/src/main/java/org/jackhuang/hmcl/download/MojangDownloadProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_org.jackhuang.hmcl.Launcher_20240820015116.mp4
_org.jackhuang.hmcl.Launcher_20240820015917.mp4
https://github.com/zkitefly/unlisted-versions-of-minecraft
Close #2481