fix: serialization #3080
Open
fix: serialization #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这会直接修改整个 Config 的序列化逻辑。请针对性修复 |
burningtnt
suggested changes
May 27, 2024
| @@ -60,6 +61,7 @@ public final class Config implements Cloneable, Observable { | |||
| .registerTypeAdapter(EnumBackgroundImage.class, new EnumOrdinalDeserializer<>(EnumBackgroundImage.class)) // backward compatibility for backgroundType | |||
| .registerTypeAdapter(Proxy.Type.class, new EnumOrdinalDeserializer<>(Proxy.Type.class)) // backward compatibility for hasProxy | |||
| .setPrettyPrinting() | |||
| .setObjectToNumberStrategy(ToNumberPolicy.LONG_OR_DOUBLE) | |||
There was a problem hiding this comment.
具体来说呢，有大整数必须double不能long的场景吗？这只是让gson先尝试序列化成long，如果解析失败还是double
There was a problem hiding this comment.
要不只能改那一坨fromStorage的屎山了，我觉得大整数用double是十分少见的
|
应当针对性解决。超时关闭 |
Glavo
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不好评价，为人么有人序列化不直接写好class啊……
时间戳反序列化成了double，绝
解决了 #2620 (comment) 提到的重复登录的bug
作为进一步实现临时登录之前的一个小fix