Mutual coupling fix #248
Merged
Mutual coupling fix #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jones matrix reordering step was fixed so that the shapes used in calculation are (n_directions, n_freqs, n_feeds, n_axes). Prior to this, the last two axes were swapped. The overall scaling of the coupling coefficients was also not updated correctly when the calculation was updated a few commits ago--it was scaled by the frequency rather than the wavelength. This has been fixed.
Make things work again after changing the simulation routine.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Just seeing if this will fix the annoying poetry error when building the linter.
for more information, see https://pre-commit.ci
Codecov ReportBase: 96.52% // Head: 96.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 96.52% 96.55% +0.03%
==========================================
Files 24 24
Lines 3019 3046 +27
==========================================
+ Hits 2914 2941 +27
Misses 105 105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ra_sim into mutual_coupling_fix
for more information, see https://pre-commit.ci
steven-murray
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
This all looks good to me! Thanks @r-pascua for all the hard work.
14 tasks
It should only have one factor of omega_p. Also improved the class documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mutual coupling simulation routine to correctly use the provided
UVBeamobjects. See this memo for details.