fix: allow to use numpy 2 and pyuvdata 3 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdillon
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Looks good. Thanks so much @steven-murray for all this! Just a few small questions and I think we'll be good to go.
…o numerical issues with chi^2 in test_expand_omni_sol
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 97.27% 97.21% -0.07%
==========================================
Files 31 31
Lines 10950 10987 +37
==========================================
+ Hits 10652 10681 +29
- Misses 298 306 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsdillon
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some warnings and errors from pyuvdata 3 and numpy 2.
This depends on HERA-Team/hera_qm#464 and RadioAstronomySoftwareGroup/pyuvdata#1459