Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace np.Inf with np.inf #70

Merged
merged 4 commits into from
Jul 1, 2024
Merged

fix: replace np.Inf with np.inf #70

merged 4 commits into from
Jul 1, 2024

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Jun 29, 2024

Enables numpy 2 support by replacing np.Inf with np.inf

Also adds warnings tests to CI so we spot these issues earlier.

@steven-murray steven-murray requested a review from bhazelton June 29, 2024 10:29
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.44%. Comparing base (9a5bb4b) to head (893b30b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   47.44%   47.44%           
=======================================
  Files          20       20           
  Lines        2312     2312           
=======================================
  Hits         1097     1097           
  Misses       1215     1215           
Flag Coverage Δ
unittests 47.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about the new CI

@steven-murray steven-murray merged commit 1207234 into main Jul 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants