Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added epel/umd repositories #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2018

Added repositories class to add EPEL and UMD repositories.

In the instruction:

Argus Service Deployment for 1.7 version — Argus Documentation 1.7.0 documentation

it says:

EL7/x86_64 with the EPEL, CERN WLCG and UMD4 repositories enabled.

But WLCG repository seems not used, therefore it is not included.
(I may miss something, or it is needed for other services?)

@kreczko
Copy link
Member

kreczko commented Oct 16, 2018

This is way is definitely better than creating the .repo files.
In the past we always wanted to give the freedom to disable/enable extra repos without the puppet module breaking the desired setting.

@cajbrew @rwf14f What do you think?

@rwf14f
Copy link
Contributor

rwf14f commented Oct 17, 2018

I agree with Luke, we need a way to enable/disable extra repositories to allow users to deploy repositories by other means, eg this change would break our setup because we have a separate module that deals with configuring the required repositories.

'RedHat': {
package { 'epel-release':
ensure => installed,
provider => rpm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the rpm provider require a source ?

@afortiorama
Copy link
Member

Module was originally mine. I agree that the repository setup has to be flexible if added. Fixed choice of repositories setup always creates problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants