-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for changes in allegro ecal segmentation. #135
Conversation
The allegro ecal segmentation class has been changed to properly return a position in the volume-local coordinate system. Remove the workaround here that was dealing with what the segmentation used to return.
Depends on PR#1384 from DD4hep (AIDASoft/DD4hep#1384) and PR#423 from k4geo (key4hep/k4geo#423). |
Now that the k4geo change was merged, this should also get merged. Otherwise, cell positions will be wrong. |
The failures are because we're not seeing the updated version of k4geo, on which this depends. |
Hi @scott-snyder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, they are basically straightforward given the way the underlying code in k4geo (and DD4hep) has been reshuffled.
Maybe one comment is that the release notes are a bit misleading, the reader could think that the cells were badly positioned before, which is not the case - the user will get the same positioning with this positioning tool before/after changes.
Thanks. I tried to update the description slightly to be clearer. |
Mmm ok, for k4RecCalorimeter it usually suffices that the tests are passed for the nightlies for us to accept the pr.. |
I just ran the CI and the nightlies pass @giovannimarchiori. The release fails as expected. |
Tests for nightlies passed successfully, going to merge |
just to confirm that with 1000 photon events (10 GeV, theta between 50 and 130 degrees) the cell positions (with the position tool) are identical before/after merging this PR, and that the hits from the readout (summing the G4 steps with same cellID) have now the proper z position |
The allegro ecal segmentation class has been changed to properly return a position in the volume-local coordinate system. Remove the workaround here that was dealing with what the segmentation used to return.
BEGINRELEASENOTES
ENDRELEASENOTES