(Add) Forum last edit #4288
Open
(Add) Forum last edit #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roardom
suggested changes
Oct 28, 2024
Obi-Wana
force-pushed
the
add-forum-edit
branch
2 times, most recently
from
8c0edf7 to
607de57
Compare
Roardom
reviewed
Oct 31, 2024
Roardom
reviewed
Oct 31, 2024
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
607de57 to
3723887
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
d8bcb0c to
de52951
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
26aa46d to
5a6274a
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
ec711d4 to
e5f1341
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
dc26a99 to
ff8bacd
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
f758bbe to
d104844
Compare
Roardom
suggested changes
Jan 21, 2025
| @@ -289,8 +310,8 @@ | |||
| } | |||
|
|
|||
| .post__header { | |||
| grid-template-areas: 'datetime topic . tip-stats overflow' '. . . . toolbar'; | |||
| grid-template-columns: auto auto 1fr auto auto; | |||
| grid-template-areas: 'datetime edited topic . tip-stats overflow' '. . . . toolbar'; | |||
There was a problem hiding this comment.
There are now 6 columns in the first row but only 5 in the second.
Comment on lines
+274
to
+281
| .post__updated-dropdown { | ||
| display: none; | ||
| background-color: var(--top-nav-dropdown-menu-item-hover-bg); | ||
| position: absolute; | ||
| padding: 5px; | ||
| box-shadow: var(--post-shadow); | ||
| border-radius: 5px; | ||
| border: var(--bbcode-input-border); |
There was a problem hiding this comment.
You can't use non --post- prefixed colors here. You can add new --post- colors to every theme if you like. As is, the colors here (taken from top nav and bbcode) don't seem to fit the styles very well either.
Comment on lines
-41
to
+43
| grid-template-areas: 'datetime topic . tip-stats toolbar'; | ||
| grid-template-columns: auto auto 1fr auto auto; | ||
| grid-template-areas: '. . topic . tip-stats toolbar'; | ||
| grid-template-columns: auto auto auto 1fr auto auto; |
There was a problem hiding this comment.
You can delete the two empty left-most columns here, they're not being used for anything.
| • edited | ||
| <i class="{{ config('other.font-awesome') }} fa-caret-down"></i> | ||
| <div class="post__updated-dropdown"> | ||
| {{ $post->updated_at?->diffForHumans() }} |
There was a problem hiding this comment.
This should be wrapped in a <time> element and have matching attributes as all the other <time> elements (namely datetime and title of the raw database value)
| grid-template-columns: 1fr auto auto; | ||
| border-top: 2px solid var(--post-aside-bg); | ||
| padding: 4px; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| font-size: 13px; | |
| } |
Comment on lines
+325
to
+326
| grid-template-areas: '. . topic tip-stats overflow' '. . . . toolbar'; | ||
| grid-template-columns: auto auto auto 1fr auto auto; |
There was a problem hiding this comment.
The two left-most empty columns can be deleted here.
| { | ||
| Schema::table('posts', function (Blueprint $table): void { | ||
| $table->unsignedInteger('updated_by')->nullable()->after('updated_at'); | ||
| $table->foreign('updated_by')->references('id')->on('users')->cascadeOnUpdate()->cascadeOnDelete(); |
There was a problem hiding this comment.
null on delete would be better here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "last edited by " to forum posts.
Suggestions for better naming instead of
updatedByare welcome.