Implement type conversion for simple numeric types #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
type_conversion
branch
from
9aa41ed to
912af3a
Compare
mattjala
force-pushed
the
type_conversion
branch
from
912af3a to
3dc9833
Compare
mattjala
force-pushed
the
type_conversion
branch
from
3dc9833 to
21c97eb
Compare
| &transfer_info[i].tconv_buf, &transfer_info[i].bkg_buf, NULL, &fill_bkg); | ||
|
|
||
| /* Perform type conversion on response values */ | ||
| memset(transfer_info[i].tconv_buf, 0, file_type_size * (size_t)mem_select_npoints); |
There was a problem hiding this comment.
Since TRUE is passed above for clear_tconv_buf, there's no need to memset it here since it will be allocated with calloc
| "failed to parse member of compound type"); | ||
|
|
||
| if (RV_json_values_to_binary_recursive(member_val, member_dtype_id, | ||
| (void *)((char *)value_buffer + offset)) < 0) |
There was a problem hiding this comment.
This will probably work for packed compound types, but if the compound datatype has padding in it in the same way that the natural C struct likely does, this will be problematic. Best to use H5Tget_member_offset to get the member offsets instead of assuming they're linearly next to each other
jhendersonHDF
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the helpers here are copied from the DAOS VOL's datatype code.
Tests for this are implemented in HDFGroup/vol-tests#62.
Fix for #6