New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows CI and build script #127

Merged

jhendersonHDF merged 20 commits into HDFGroup:master from mattjala:windows_compatibility

Jan 10, 2025

Collaborator

mattjala commented Apr 15, 2024 •

edited

Loading

Added workflow to build and test on Windows with CMake
Populated build_vol_cmake.bat to replicate build_vol_cmake.sh
Various CMake changes so that YAJL and cURL can be discovered on Windows. The github runners don't seem to have a FindCURL module, so the CMake now defines CURL_LIBRARIES and CURL_INCLUDE_DIRS relative to the provided CURL_ROOT.

Changes to the VOL for Windows compatibility:

Replaced clock_gettime with RV_now_usec, which uses one of clock_gettime, gettimeofday, or time.
Replaced strtok_r with cross-platform strtok

Resolves #116

mattjala added enhancement testing labels

mattjala self-assigned this

mattjala force-pushed the windows_compatibility branch 3 times, most recently from fc8789f to 2b1fc5a Compare

April 15, 2024 19:54

mattjala marked this pull request as ready for review

April 19, 2024 22:06

mattjala requested a review from jhendersonHDF as a code owner

April 19, 2024 22:06

mattjala force-pushed the windows_compatibility branch from a722d69 to 57aac6c Compare

April 19, 2024 22:11

jhendersonHDF reviewed

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

jhendersonHDF reviewed

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

jhendersonHDF reviewed

View reviewed changes

src/rest_vol.c Outdated Show resolved Hide resolved

jhendersonHDF reviewed

View reviewed changes

CMake/FindYAJL.cmake Outdated Show resolved Hide resolved

jhendersonHDF reviewed

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

mattjala force-pushed the windows_compatibility branch from 1de37ac to 6290d43 Compare

June 4, 2024 21:33

mattjala and others added 15 commits

January 10, 2025 11:39


          Use gettimeofday if clock_gettime not defined

dc38c95


          Fix YAJL cmake import on Windows

578224b


          Use cross-platform strtok

9a2cafd


          Fallback to time() if gettimeofday not found

414f8fe


          Committing clang-format changes

1bf6e5e


          Add windows CI and build script

f39b549


          Test REST VOL in Windows workflow

1f4c272


          Bump CMake min to 3.12, remove max

e84f936


          Remove manual root dir creation

949f7c6

Since HDFGroup/hsds#357, the 'data' directory already exists.


          Fix typo in FindYAJL

fbbcbb3


          Implement RV_strtok_r

c369993


          Remove extraneous export library

afe0535


          Add strok_r check to autotools

3948cc9


          Add time func checks to autotools

0d59bf3


          Remove redundant export lib

1e80108


          Use FindCURL module when CURL built with CMake

71f298b

mattjala force-pushed the windows_compatibility branch from 6290d43 to 71f298b Compare

January 10, 2025 17:41

mattjala added 2 commits

January 10, 2025 11:56


          Fix non-windows CI

391da36


          Disable libidn and libpsl for CI curl install

5b57602

jhendersonHDF reviewed

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

jhendersonHDF reviewed

View reviewed changes

build_vol_cmake.sh Outdated Show resolved Hide resolved

mattjala added 2 commits

January 10, 2025 14:44


          Remove hardcoded CMake config for curl

86df3b5


          Fix cmake build script

3c6bbf9

jhendersonHDF approved these changes

View reviewed changes

jhendersonHDF merged commit 97fec4c into HDFGroup:master

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement testing