Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sunton esp32-2432s024{r,c} #750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinloaf
Copy link

@tinloaf tinloaf commented Jun 7, 2024

This adds support for the Sunton esp32-2432s024{r,c} displays.

This is based on the code contributed by @elik754i in #555 . A few caveats:

  • I do not own an esp32-2432s024r, only an esp32-2432s024c. So I cannot vouch that the "r" variant works. I have tested the "c" variant and it works.
  • It looks like @elik745i added the support for the CST820 touch controller to an older version of the tft_driver_lovyangfx.cpp file than the version in the openHASP repo. I transplanted the necessary changes into the file in this repo. I do not know where they got that code from and I cannot read the chinese comments, but it seems to work.
  • I am not sure about the naming. I think I read somewhere that the esp32 on these boards is an 'ESP32 S3', so I put the user-config into the esp32s3 folder, but I'm not sure what an 's2' or 's3' esp32 is or whether this is correct in this case.
  • I'm not sure about the naming of the build environments. Some of the Sunton boards' environments seem to be named sunton-<whatever>, others just esp32-<whatever>. I opted for the latter, but feel free to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants