Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/review] 리뷰 도메인 리팩토링 #131

Merged
merged 21 commits into from
Dec 31, 2023
Merged

Conversation

onetuks
Copy link
Contributor

@onetuks onetuks commented Dec 13, 2023

No description provided.

@onetuks onetuks added the enhancement New feature or request label Dec 13, 2023
@onetuks onetuks requested review from byeolhaha and wonu606 December 13, 2023 07:53
@onetuks onetuks self-assigned this Dec 13, 2023
Copy link
Contributor

@wonu606 wonu606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋 단위를 잘 나누어주셔서 코드 보기 편했습니다.
수고하셨습니다!

.stream()
.map(ChildFindResult::childId)
.toList();

reviewFacade.removeReview(memberId);
reviewFacade.removeReview(member);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디스코드에서 이야기 나누었던 직접 참조 부분이 여기라고 생각하는데 맞을까요?
저는 직접 참조해도 괜찮다고 생각합니다!

@onetuks onetuks merged commit 6ebcf84 into develop Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants