Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 전적 페이지 게임 날짜 시간 #500

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

nyj001012
Copy link
Collaborator

@nyj001012 nyj001012 commented Mar 13, 2024


✅ 풀_리퀘스트 체크리스트

  • PR 제목: [feat/fix/refactor...] 작업 내용 한 줄 요약 (브랜치 이름) #이슈번호
  • commit message 가 적절한지 확인해주세요.
  • 적절한 branch 로 요청했는지 확인해주세요.
  • Assignees, Label 을 붙여주세요.
  • 주의 사항과 관련해 꼭 확인해야 할 사람이 있다면 Reviewer 로 등록해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제해 주세요!

🔄 변경 사항

무엇을 합니다!

  • 전적 페이지에서 승률 소수점 밑 두 자리까지만 출력
  • 모드 이름 변경(1 vs 1 모드, 토너먼트, 랭크 토너먼트)

📎 변경한 이유

  • 포맷팅

closes: #443

👨🏻‍💻 테스트 체크리스트

  • e2e

📌 변경 및 주의 사항


@nyj001012 nyj001012 added enhancement New feature or request frontend frontend 관련 PR labels Mar 13, 2024
@nyj001012 nyj001012 self-assigned this Mar 13, 2024
@nyj001012 nyj001012 linked an issue Mar 13, 2024 that may be closed by this pull request
Comment on lines -27 to 29
tournament: "토너먼트 모드",
casual_tournament: "토너먼트 모드",
rank: "랭크 토너먼트",
one_on_one: "1 vs 1 모드",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 낫네요 bb

Comment on lines +23 to +25
const [hour, minute, second] = timeString.split(":");
return (
hour.split(".")[0] + ":" + minute.split(".")[0] + ":" + second.split(".")[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나이스한 구조분해할당 코드같습니다요

@nyj001012 nyj001012 merged commit 1f16732 into main Mar 13, 2024
6 checks passed
@nyj001012 nyj001012 deleted the 443-bug-전적-페이지-게임-날짜-시간 branch March 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend 관련 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] 전적 페이지 게임 날짜, 시간
2 participants