Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 최종 제출 레포 제작 #490

Merged
merged 7 commits into from
Mar 13, 2024
Merged

feat: 최종 제출 레포 제작 #490

merged 7 commits into from
Mar 13, 2024

Conversation

sejoonkimmm
Copy link
Contributor

📌 변경 및 주의 사항

  1. crs-setup의 paranoia-level을 수정했습니다. 보다 상세한 방어가 가능합니다.
  2. django-log의 I/O 권한 문제가 아이맥에서 간헐적으로 발생함을 확인하였습니다. 이에 권한을 수정하였습니다.
  3. ELK Stack을 위해 Log가 파일에 찍히도록 수정하였습니다.
  4. Dashboard에 [시작] 태그가 거슬려 grok filter로 삭제하였습니다.
  5. nginx가 되돌려받은 요청 시간이 0일 경우 자체적으로 삭제하여 Elasticsearch에서 보내는 것으로 수정하였습니다.
  6. Modsecurity를 모두 활성화했습니다. 빌드 시간이 15분 정도 걸립니다.
  7. conf 파일에 주석을 달아 평가 때 유연한 설명이 가능하도록 했습니다.
  8. page.js 파일에 bar 데이터를 data.data.bar.width 로 받도록 수정하였습니다.

@sejoonkimmm sejoonkimmm added enhancement New feature or request backend backend 관련 PR frontend frontend 관련 PR labels Mar 12, 2024
@sejoonkimmm sejoonkimmm self-assigned this Mar 12, 2024
@sejoonkimmm sejoonkimmm linked an issue Mar 12, 2024 that may be closed by this pull request
feat: 최종 제출 브런치 제작 #489
Closed
donghyun1998
donghyun1998 approved these changes Mar 12, 2024
View reviewed changes
frontend/src/pages/online-game/page.js Outdated
Comment on lines 86 to 87
bar1.width = data.data.bar.width;
bar1.height = data.data.bar.height;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data.data.bar였군요 아놔
수정 고생하셨습니다!

nyj001012
nyj001012 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제출 전 걸려있던 주석들 전부 풀렸네요. 확인했습니다.

bluedog129
bluedog129 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@bluedog129 bluedog129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아름답군요 다들 수고 많으셨습니다!

@sejoonkimmm sejoonkimmm merged commit cbcb0f0 into main Mar 13, 2024
1 check passed
@sejoonkimmm sejoonkimmm deleted the 489-feat-최종-제출-브런치-제작 branch March 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donghyun1998 donghyun1998 donghyun1998 approved these changes

@bluedog129 bluedog129 bluedog129 approved these changes

@nyj001012 nyj001012 nyj001012 approved these changes

@LWJ0513 LWJ0513 Awaiting requested review from LWJ0513

Assignees

@sejoonkimmm sejoonkimmm

Labels
backend backend 관련 PR enhancement New feature or request frontend frontend 관련 PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 최종 제출 브런치 제작
4 participants
@sejoonkimmm @nyj001012 @bluedog129 @donghyun1998