feat: online-game 모든 로직 비동기로 변경 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bluedog129
approved these changes
Mar 12, 2024
|
|
||
| const init = () => { | ||
| initMyInfo(); | ||
| const init = async () => { |
nyj001012
approved these changes
Mar 12, 2024
|
해당 코드로 평가까지 달리겠습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 풀_리퀘스트 체크리스트
🔄 변경 사항
비동기 함수인 getUserMe가 반환 된 이후에 전체 로직이 실행되어야 합니다.
기존 코드의 경우 getUserMe의 반환과 관계없이 이후 렌더링 로직이 실행되어 오류가 생겼습니다.
때문에 실행 시 콜스택에 들어가는 메인 로직을 전부 async함수 안으로 넣어 순서 보장하게 했습니다.
history 페이지로 넘길 때 웹소켓 연결 끊어줬습니다.
TODO, console.log 제거했습니다.
online-game bar width height 고정값이던거 서버기준으로 변경했습니다.
closes: #484