Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match3 로직 추가 완료 #470

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

donghyun1998
Copy link
Contributor

@donghyun1998 donghyun1998 commented Mar 11, 2024


✅ 풀_리퀘스트 체크리스트

  • PR 제목: [feat/fix/refactor...] 작업 내용 한 줄 요약 (브랜치 이름) #이슈번호
  • commit message 가 적절한지 확인해주세요.
  • 적절한 branch 로 요청했는지 확인해주세요.
  • Assignees, Label 을 붙여주세요.
  • 주의 사항과 관련해 꼭 확인해야 할 사람이 있다면 Reviewer 로 등록해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제해 주세요!

🔄 변경 사항

match3 페이지에서 소켓 메시지 받아서 동적렌더링 해 주고 싶었는데 어려워서 못하겠습니다..
그냥 online-game 페이지에서 기다리다가 같이 matchup으로 넘겼어요

closes: #469


@donghyun1998 donghyun1998 added enhancement New feature or request frontend frontend 관련 PR labels Mar 11, 2024
@donghyun1998 donghyun1998 self-assigned this Mar 11, 2024
@donghyun1998 donghyun1998 linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Collaborator

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match3를 기준으로 분기 처리하신 것 확인했습니다. 고생 많으셨어요.

Copy link
Contributor

@sejoonkimmm sejoonkimmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 너무 잘 읽히네용! 전달되는 값들 차이 문제만 없다면 잘 될 것 같습니다 고생하셨어용~~~!

Copy link
Contributor

@bluedog129 bluedog129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match3로직 구현 잘 봤습니다 수고 많으셨습니다!

@@ -26,7 +21,7 @@ export default function Matchup($container, info = null) {
} else {
console.error("No match data available");
}
setCards(data.data.data.match3);
setCards(info.data.data.match3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 info였군요 고쳐주셔서 감사합니다!

@donghyun1998 donghyun1998 merged commit 113d555 into main Mar 12, 2024
1 check passed
@donghyun1998 donghyun1998 deleted the 469-feat-match3-로직-갈아엎기 branch March 12, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend 관련 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: match3 로직 갈아엎기
4 participants