[Ready for review] Core dependency and tool updates with PHP 8.1 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make boot fix with php 8.1 bumped dependencies refactored rector config file refactored github workflows added temporary phpstan baseline to keep track on what to fix phpstan; resolved meilisearch incorrect case phpstan; added phpstan phpunit dev depenecies; started fixing tests removing doctrine annotations; replaced document annotation with attribute; further fixing tests phpunit fixed errors, left with 19 failures fixed test regarding document reader bumped psr/log constraint fixed constraints back for apt in dockerfile no lowerest composer install for phpcs phpstan and phpunit workflows ran phpcs fixer with created config ran phpcs fixer for tests directory updated phpstan parameters added gitattributes, updated gitignore, removed composer.lock fixed renaming annotation to attribute in docs + composer.json tests namespace updated rector with skip rules ran rector + phpcsfixer updated badges for workflows in readme fixed typo in readme updated readme for support 8.1 and up phpunit fixes; left with search extension failure test phpunit resolved final test cases tried running infection with fixed config; i have no idea what core files are that are generated phpstan ignoreerrors and start fixing reformating codestyle phpstan issues resolved mostly by phpdoc typing ran phpcsfixer updated gitattributes added command attributes added asmessagehandler attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Hey @Guikingone 👋
Took me couple of days after but here's my shot at updating the bundle. I went straight to PHP 8.1 (as 8.0 is EOL next week). While I haven't tested it manually in one of my projects yet, the unit tests are (finally) passing 😌
While updating the code quality tools (phpcs, phpunit, phpstan) I've took the liberty to incorperate some addtional Github workflows. Hope that's not a major dealbreaker.
I'd appreciate if you have the time to review it and give feedback. You're also more than welcome to make any changes to the PR yourself if you think it's needed.
Let me know 🙂