Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move setupmodelparameters from each model to abstractNMM #157

Closed
wants to merge 19 commits into from
Closed

move setupmodelparameters from each model to abstractNMM #157

wants to merge 19 commits into from

Conversation

JohnWangDataAnalyst
Copy link
Collaborator

@JohnWangDataAnalyst JohnWangDataAnalyst commented Jan 16, 2024

  1. move setupmodelparameters from each model to abstractNMM
  2. broke example 2 and 5
  3. modified the code to make example 2 working (using evaluate method)
  4. example 5 (just gpu the new version code incudes the case with multiple blocks, we better use the new version to show how gpu works ) we could just set each par with device as gpu to test it?
  5. another reason we should use the new example in zheng_dev for the multimodal is that the examples shown in this repo is fitted to the target value of state E from RWW and did not use the empirical eeg and bold in the cost function, which is actually not a multimodal fitting
  6. separating the eeg and bold modules from nmm model is a good idea. In the new version we have those options. modal fitting uses the same script for all the models

@Andrew-Clappison
Copy link
Collaborator

Andrew-Clappison commented Jan 23, 2024

This is part of splitting #143 and #144 into smaller PR chunks. Comments also in those closed commits.

Commit 1008fa has a modified ipyb which will add to package size even though it is reverted in a later commit. Modified/reverted in later commits.
It appears the bifurcation objective function component feature which is being used in a paper is removed. Some other objective function simplifications also done.
empRec data object removed, and eg002 content and figures at end commented out/deleted. Content of eg005 commented out or deleted.
Priors added directly in RWWEI2 model class, but in abstract class for other models. RWWEI2 model no longer inheriting from abstracts.
Some transparency from method arguments is removed and made non-optional.

Above is regards to larger changes, changes to equations and code require more detailed review.

@JohnWangDataAnalyst
Copy link
Collaborator Author

will resubmit it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants