Skip to content

Commit

Permalink
Merge pull request #366 from Julusian/nodata-colspan
Browse files Browse the repository at this point in the history
NoData Component has no colspan
  • Loading branch information
ryanlanciaux committed Mar 23, 2016
2 parents 2561e74 + b90b033 commit aa844de
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion build/Griddle.js
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,8 @@ return /******/ (function(modules) { // webpackBootstrap

// no data section
if (this.props.showNoData) {
nodes.push(React.createElement('tr', { key: 'no-data-section' }, React.createElement('td', null, this.props.noDataSection)));
var colSpan = this.props.columnSettings.getVisibleColumnCount();
nodes.push(React.createElement('tr', { key: 'no-data-section' }, React.createElement('td', { colSpan: colSpan }, this.props.noDataSection)));
}

// Add the spacer rows for nodes we're not rendering.
Expand Down
3 changes: 2 additions & 1 deletion build/griddle.js
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,8 @@ return /******/ (function(modules) { // webpackBootstrap

// no data section
if (this.props.showNoData) {
nodes.push(React.createElement('tr', { key: 'no-data-section' }, React.createElement('td', null, this.props.noDataSection)));
var colSpan = this.props.columnSettings.getVisibleColumnCount();
nodes.push(React.createElement('tr', { key: 'no-data-section' }, React.createElement('td', { colSpan: colSpan }, this.props.noDataSection)));
}

// Add the spacer rows for nodes we're not rendering.
Expand Down
3 changes: 2 additions & 1 deletion scripts/gridTable.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ var GridTable = React.createClass({

// no data section
if (this.props.showNoData) {
nodes.push(<tr key="no-data-section"><td>{this.props.noDataSection}</td></tr>);
var colSpan = this.props.columnSettings.getVisibleColumnCount();
nodes.push(<tr key="no-data-section"><td colSpan={colSpan}>{this.props.noDataSection}</td></tr>);
}

// Add the spacer rows for nodes we're not rendering.
Expand Down

0 comments on commit aa844de

Please sign in to comment.