Fix Fluid Cells having hard coded(and wrong) fluid properties #2927
+30
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghostipedia
approved these changes
Mar 3, 2025
krossgg
requested changes
Mar 3, 2025
| .setData(ProviderType.ITEM_MODEL, NonNullBiConsumer.noop()) | ||
| .properties(p -> p.stacksTo(stackSize)) | ||
| .onRegister(attach(cellName(), | ||
| ThermalFluidStats.create(FluidType.BUCKET_VOLUME * capacity, |
There was a problem hiding this comment.
Make overload that takes in a mat instead of the individual values
| @@ -476,6 +423,26 @@ public Component getItemName(ItemStack stack) { | |||
| .onRegister(materialInfo(new ItemMaterialInfo(new MaterialStack(GTMaterials.Glass, GTValues.M / 4)))) | |||
| .register(); | |||
|
|
|||
| public static ItemEntry<ComponentItem> createFluidCell(Material mat, int capacity, int matSize, int stackSize) { | |||
| String name = "%s " + mat.getLocalizedName() + " Cell"; | |||
There was a problem hiding this comment.
Why is this not just inlined in .lang()
| var prop = mat.getProperty(PropertyKey.FLUID_PIPE); | ||
| if (prop == null) prop = GTMaterials.Wood.getProperty(PropertyKey.FLUID_PIPE); | ||
| return REGISTRATE | ||
| .item("%s_fluid_cell".formatted(mat.getName()), ComponentItem::create) |
There was a problem hiding this comment.
please ensure that this doesn't result in missing IDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the various large fluid cells having hard coded values for the fluid properties, as some were wrong
Implementation Details
use the fluid pipe property instead for the ThermalFluidStats
Outcome
you can use stainless as an acid holder again :)