Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Miner #2910

Open
wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
Open

Conversation

omergunr100
Copy link
Contributor

@omergunr100 omergunr100 commented Feb 26, 2025

What

Makes the output side configurable.
Changes the front overlay to be the same as other sides.
Prevents insertion into the miner output via conveyors.
Set rotation state to non y-axis since it always mines downwards.
Prevent setting down as the output face since the pipe goes there.

Potential Compatibility Issues

Any miners placed before the update will have their output side reset.

prevent insertion to miner inventory using conveyors.
@omergunr100 omergunr100 requested a review from a team as a code owner February 26, 2025 13:27
@omergunr100 omergunr100 added type: refactor Suggestion to refactor a section of code Merge on Major Release Breaking changes, must be bundled into an 1.X.0 Update labels Feb 26, 2025
prevent setting down as the output direction.
@omergunr100
Copy link
Contributor Author

Should note that when #2823 gets merged we could make the single-block miners able to rotate upwards properly and mine upwards like the large ones can.
At which point some of the changes I made here need to be revised if that's the wanted behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge on Major Release Breaking changes, must be bundled into an 1.X.0 Update type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant