-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send chat message when new ore veins are prospected #2902
base: 1.20.1
Are you sure you want to change the base?
Send chat message when new ore veins are prospected #2902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message not being sent was a recent change (idk if intentional or not).
I still think that if a message is sent it should mention the type of vein, otherwise it's sort of pointless since you can already see the veins on the prospector widget.
src/main/java/com/gregtechceu/gtceu/integration/map/cache/client/GTClientCache.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotlessApply
🗣️
You didn't undraft it too
What
Sends a chat message when new ore veins are prospected. The message contains the vein name tinted with the color of the first ore in the vein, and the chunk location of the vein
Implementation Details
Uses previously unused
GTClientCache.notifyNewVeins
methodOutcome
Sends a message now
Potential Compatibility Issues
None hopefully!