Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send chat message when new ore veins are prospected #2902

Open
wants to merge 7 commits into
base: 1.20.1
Choose a base branch
from

Conversation

JuiceyBeans
Copy link
Contributor

@JuiceyBeans JuiceyBeans commented Feb 23, 2025

What

Sends a chat message when new ore veins are prospected. The message contains the vein name tinted with the color of the first ore in the vein, and the chunk location of the vein

Implementation Details

Uses previously unused GTClientCache.notifyNewVeins method

Outcome

Sends a message now

Potential Compatibility Issues

None hopefully!

@JuiceyBeans JuiceyBeans requested a review from a team as a code owner February 23, 2025 18:11
Copy link
Contributor

@omergunr100 omergunr100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message not being sent was a recent change (idk if intentional or not).
I still think that if a message is sent it should mention the type of vein, otherwise it's sort of pointless since you can already see the veins on the prospector widget.

@omergunr100 omergunr100 added the type: feature New feature or request label Feb 24, 2025
@JuiceyBeans JuiceyBeans marked this pull request as draft February 26, 2025 13:57
Copy link
Contributor

@omergunr100 omergunr100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotlessApply 🗣️
You didn't undraft it too

@JuiceyBeans JuiceyBeans marked this pull request as ready for review February 26, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants