Refactor JourneyMap integration #2877
Open
+81
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
requested changes
Feb 16, 2025
src/main/java/com/gregtechceu/gtceu/integration/map/journeymap/JourneymapEventListener.java
Show resolved
Hide resolved
it was never supported, we should honestly just get rid of all the map compat configs that don't make sense. |
|
maybe replace them with the ability to set the position of the toolbar manually: |
screret
approved these changes
Feb 28, 2025
YoungOnionMC
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fuck it unmixins your JourneyMap integration.
Implementation Details
Replace the mixin with an event listener.
Outcome
Resolves #2867