Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate a tool into tool tags and crafting tags #2810

Open
wants to merge 6 commits into
base: 1.20.1
Choose a base branch
from

Conversation

GirixK
Copy link
Contributor

@GirixK GirixK commented Feb 1, 2025

What

This PR gives each GTToolType a new tag, crafting recipes would use this tag instead, allowing pack and addon creators to introduce a separation between usable tools and crafting tools

Implementation Details

Adding a new ModTag and moving it to be the first tag on the item

Potential Compatibility Issues

  • If two tag groups (for example in this case #forge:tools/wrenches and #gtceu:tools/crafting_wrenches) are identical, and contain all the same items, one will be hidden from EMI, this is apparently intended behaviour, so the tag will not show in EMI
  • I'm not sure what other features rely on reading the index of the tool's tags, meaning some things might be broken within the mod
  • Other mods' hammers and similar will not work for crafting plates or otherwise (beneficial change in some cases, according to Maya)
  • Breaking recipes which manually specify tags, instead of using VanillaRecipeHelper's tool chars

@omergunr100 omergunr100 added the type: refactor Suggestion to refactor a section of code label Feb 1, 2025
@GirixK GirixK marked this pull request as ready for review February 12, 2025 08:58
@GirixK GirixK requested a review from a team as a code owner February 12, 2025 08:58
@krossgg krossgg added the Merge on Major Release Breaking changes, must be bundled into an 1.X.0 Update label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge on Major Release Breaking changes, must be bundled into an 1.X.0 Update type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants