Make Electric Wire Cutters have consistent item IDs #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krossgg
added
Do Not Merge
Ghostipedia
added
Merge on Major Release
krossgg
force-pushed
the
giri/wirecutter-id-fix
branch
from
6375b38 to
d6c5c8b
Compare
|
Items no longer cease to exist - IDs now get remapped. |
YoungOnionMC
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The item ID of electric wire cutters was for example
"iv_%s_wirecutter", which is inconsistent with the non-electric version, as well as the tag#forge:tools/wire_cuttersOutcome
Note the ID changed
Potential Compatibility Issues
This will cause all existing items to cease existence