Skip to content

Commit

Permalink
Merge branch 'junghee/test-lea-sym-minus-sym' into 'main'
Browse files Browse the repository at this point in the history
Junghee/test lea sym minus sym

See merge request rewriting/ddisasm!1231
  • Loading branch information
jdorn-gt committed Nov 21, 2024
2 parents c1d75b8 + 34c0844 commit 974c253
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
sections
* Fix 16-Thumb STM instructions considered to be invalid if the same register
is used in reglist and register operands with writeback enabled.
* Fixed bug that could result in missed symbolic expressions with TLS variables for `local-executable` TLS model
* Fix bug that could result in missed symbolic expressions with TLS variables for `local-executable` TLS model
* Fix bug that caused assembling error due to wrong `symbol_minus_symbol`
for lsda entries with references to the end of `.gcc_except_table`
* Generate alignments for function entry blocks depending on address
* Fixed bug that could result in missed symbolic expressions
* Fix bug that could result in missed symbolic expressions
(`symbol_minus_symbol`) in LEA

# 1.9.0
Expand Down
4 changes: 2 additions & 2 deletions src/datalog/symbolization.dl
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,8 @@ symbol_minus_symbol_candidate(EA,Size,Symbol1,Symbol2,as(Scale,unsigned),Offset)
// Similarly, before line 6, R9's value is the address of .L_4.
// After line 6 (.L_4 - 7 = .L3), R9's value is .L_3.
//
// The displacements ini the indirect operands for both the LEAs
// at line 2 and 6 need to be symbolized as
// The displacements in the indirect operands for both the LEAs
// at lines 2 and 6 need to be symbolized as
// leaq (.L_4 - .L_1)(%r9), %r9
// and
// leaq (.L_3 - .L_4)(%r9), %r9
Expand Down
13 changes: 13 additions & 0 deletions tests/linux-elf-x64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,12 @@ tests:
- name: ex_tls_local_exec
<<: *assembly

- name: ex_sym_minus_sym
<<: *assembly
test:
<<: *default-test
cfg_checks: []

# ----------------------------------------------------------------------------
# Assembly examples. (stripped)
# ----------------------------------------------------------------------------
Expand Down Expand Up @@ -611,6 +617,13 @@ tests:
<<: *assembly
<<: *test-strip-default

- name: ex_sym_minus_sym
<<: *assembly
<<: *test-strip-default
test:
<<: *default-test
cfg_checks: []

# ----------------------------------------------------------------------------
# Relocatable ELF objects (.o).
# ----------------------------------------------------------------------------
Expand Down

0 comments on commit 974c253

Please sign in to comment.