Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xray-core): new xray features #1302

Merged
merged 17 commits into from
Oct 10, 2024

Conversation

ImMohammad20000
Copy link
Collaborator

  • add noise to hosts
  • add support for splithttp new variables

app/xray/config.py Outdated Show resolved Hide resolved
app/db/models.py Outdated Show resolved Hide resolved
@fodhelper
Copy link
Contributor

because noise str must be a bytestring, and bytestrings are too long, 100 characters for noise settings is not enough
and for it's delay setting, 4 length number is better

@ImMohammad20000
Copy link
Collaborator Author

ImMohammad20000 commented Sep 6, 2024

because noise str must be a bytestring, and bytestrings are too long, 100 characters for noise settings is not enough

is 300 characters ok?

because noise str must be a bytestring, and bytestrings are too long,
100 characters for noise settings is not enough
@fodhelper
Copy link
Contributor

I have tested a short one, it's 200 characters
I guess 1000 characters will be enough even for long payloads, thank you for your useful PRs

@fodhelper
Copy link
Contributor

I captured another one and turned it to bytestring, it's 2k characters, i think it's better if you change the limit to 5000

@ImMohammad20000
Copy link
Collaborator Author

ImMohammad20000 commented Sep 7, 2024

I captured another one and turned it to bytestring, it's 2k characters, i think it's better if you change the limit to 5000

Can you send a picture or type that ?

@fodhelper
Copy link
Contributor

here is a random data for example "\xbe\x9c\x5d\x5c\x92\x7a\x30\x65\x2f\xa1\x6a\xe1\x8b\xb5\x9d\x93"
Xray turns the bytestring to bytes and uses our hardcoded bytes as noise
https://github.com/XTLS/Xray-core/blob/3d9137cb6fddbcd2e94d9811569362caf9196ccf/proxy/freedom/freedom.go#L414-L416
image

@ImMohammad20000
Copy link
Collaborator Author

I think 1000 characters is enough

@fodhelper
Copy link
Contributor

Some UDP headers are up to 2k, how you think 1000 is enough?

@ImMohammad20000
Copy link
Collaborator Author

Some UDP headers are up to 2k, how you think 1000 is enough?

I think it better to remove the character limit

@fodhelper
Copy link
Contributor

UDP Noise is getting more advanced, Look at Xray-core PRs
I think the best way to fix this and many other problems is #1210

@M03ED
Copy link
Collaborator

M03ED commented Sep 13, 2024

I think we should wait until they complete this feature then add it.

@ImMohammad20000
Copy link
Collaborator Author

I will update this to new syntax

@ImMohammad20000 ImMohammad20000 changed the title feat(xray): support xray-core v1.8.24 feat(xray-core): new xray features Sep 18, 2024
@ImMohammad20000
Copy link
Collaborator Author

ImMohammad20000 commented Sep 18, 2024

now you can use this syntax to add more than 1 noise

type:packet,delay
type:packet,delay&type:packet,delay
type:packet,delay&type:packet,delay&type:packet,delay

example:

rand:10-20,10-25
rand:10-20,10-25&str:hiGFW,10-25
rand:10-20,10-25&str:hiGFW,10-25&base64:7nQBAAABAAAAAAAABnQtcmluZwZtc2VkZ2UDbmV0AAABAAE=,10-25

@fodhelper
Copy link
Contributor

fodhelper commented Sep 28, 2024

There is a problem, if you put both maxConcurrency and maxConnections options, Xray will not get started
Adding them all with value 0 is the problem, if maxConcurrency does not exist in the server config, it must not exist in client config too, creating maxConcurrency with value 0 is not equal to not existence of it
and as already there is v2ray-settings template, there is no need to add support for xmux!

@ImMohammad20000
Copy link
Collaborator Author

There is a problem, if you put both maxConcurrency and maxConnections options, Xray will not get started
Adding them all with value 0 is the problem, if maxConcurrency does not exist in the server config, it must not exist in client config too, creating maxConcurrency with value 0 is not equal to not existence of it
and as already there is v2ray-settings template, there is no need to add support for xmux!

Is this problem stile exists in the latest version of xray core?

@fodhelper
Copy link
Contributor

Is this problem stile exists in the latest version of xray core?

No

@ImMohammad20000
Copy link
Collaborator Author

There is a problem, if you put both maxConcurrency and maxConnections options, Xray will not get started
Adding them all with value 0 is the problem, if maxConcurrency does not exist in the server config, it must not exist in client config too, creating maxConcurrency with value 0 is not equal to not existence of it
and as already there is v2ray-settings template, there is no need to add support for xmux!

So you say if there is no xmux settings we should leave it empty ?

@ImMohammad20000
Copy link
Collaborator Author

Please merge this
@M03ED @SaintShit

@ImMohammad20000
Copy link
Collaborator Author

I'll add http transport in a separate pr

@fodhelper
Copy link
Contributor

new Xray and v2rayNG versions are tagged as Release
It's time to merge it, or if any contributor don't like it, can report the problem here

@ImMohammad20000 ImMohammad20000 merged commit 4767837 into Gozargah:dev Oct 10, 2024
@ImMohammad20000 ImMohammad20000 deleted the xray-updates branch October 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants