fix the % decoding error

[alextremp]

Description

This PR fixes the #30 Issue.

Before:

• when parsing a query string containing a %, p.ex.: 'ka=va&kb=vb&kc&kd=%vd', the '%vd' decoding fails:

After:

• encoding the received data first, causes reserved chars to be valid for next decoding operation when the data is splitted and parsed separately:

Further considerations

• Current test system failed to me, so I've tested the solution with custom test code using mocha+chai for the test case. To reproduce it:

npm install mocha chai --save-dev

// ./test/indexTest.js

const expect = require('chai').expect

describe('querystring', () => {
  const qs = require('../index')
  describe('parse', () => {
    it('should parse query string key-value pairs', () => {
      const givenQS = 'ka=va&kb=vb'
      const expected = {
        ka: 'va',
        kb: 'vb'
      }
      const result = qs.parse(givenQS)
      expect(result).to.deep.equal(expected)
    })
    it('should parse query string key-only values', () => {
      const givenQS = 'ka=va&kb=vb&kc'
      const expected = {
        ka: 'va',
        kb: 'vb',
        kc: ''
      }
      const result = qs.parse(givenQS)
      expect(result).to.deep.equal(expected)
    })
    it('should parse query string with reserved chars', () => {
      const givenQS = 'ka=va&kb=vb&kc&kd=%vd'
      const expected = {
        ka: 'va',
        kb: 'vb',
        kc: '',
        kd: '%vd'
      }
      const result = qs.parse(givenQS)
      expect(result).to.deep.equal(expected)
    })
  })
})

[SidneyNemzer]

Will this prevent decoding valid percent-encoded values?

example.com?test=test%20test
// => { test: 'test test' }

[alextremp]

good point @SidneyNemzer
Yes, the change was preventing valid percent-encoded values (the original tests fail on command, so didn't test that 🤦‍♂)

Updated:

• instead of encoding the QS first, the change of this PR just adds a "safeDecodeURIComponent" that returns the decoded value or the original value if the decode fails.
• also, added a test for the commented case

Tx!

[alextremp]

closing due to no maintainers of the project, and stopped using it