Add redirect capabilities to Invest Controller #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f863efc)
davidbeig
changed the title
subiabre
previously approved these changes
Nov 27, 2024
|
There are some things missing in this PR.
|
|
@subiabre whenever you can, please |
subiabre
reviewed
Dec 4, 2024
| $return_to = ''; | ||
|
|
||
| if ($request->query->has('return_to')) { | ||
| $return_to = rawurldecode($request->query->get('return_to')); |
There was a problem hiding this comment.
Why not place the url decoding inside the isAllowedDomain static method? This way we can safely use the functionality without having to worry about the string we are passing to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
Allow the process of invest to return to an outside link.
Testing
Describe the best way to test or validate your PR.
Add the domain you want to be valid to your settings.yml under the 'url' field.
Add a &redirect_to param to the query when accessing the invest landing of any project. Follow the donation flow and get redirected to that url. The host of that url has to match one of the domains configured in the settings, if it's not the redirect won't work.