Switch workerpool_no_external_ip default (#18)

* flip flag * doc update
GoogleCloudPlatform · Mar 3, 2022 · aa1c5b3 · aa1c5b3
1 parent 0b7b900
commit aa1c5b3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/cloudbuild-private-pool/README.md b/modules/cloudbuild-private-pool/README.md
@@ -51,7 +51,7 @@ module "cloudbuild_private_pool" {
 | project\_id | Project ID for Cloud Build Private Worker Pool | `string` | n/a | yes |
 | worker\_address | Choose an address range for the Cloud Build Private Pool workers. example: 10.37.0.0. Do not include a prefix, as it must be /16 | `string` | `"10.37.0.0"` | no |
 | worker\_pool\_name | Name of Cloud Build Worker Pool | `string` | `"cloudbuild-private-worker-pool"` | no |
-| worker\_pool\_no\_external\_ip | Whether to disable external IP on the Cloud Build Worker Pool | `bool` | `true` | no |
+| worker\_pool\_no\_external\_ip | Whether to disable external IP on the Cloud Build Worker Pool | `bool` | `false` | no |
 | worker\_range\_name | Name of Cloud Build Worker IP address range | `string` | `"worker-pool-range"` | no |
 
 ## Outputs

diff --git a/modules/cloudbuild-private-pool/variables.tf b/modules/cloudbuild-private-pool/variables.tf
@@ -56,7 +56,7 @@ variable "worker_range_name" {
 variable "worker_pool_no_external_ip" {
   type        = bool
   description = "Whether to disable external IP on the Cloud Build Worker Pool"
-  default     = true
+  default     = false
 }
 
 variable "location" {