Skip to content

Commit

Permalink
deps: remove library to prevent version conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
olavloite committed Feb 6, 2025
1 parent ef8f57f commit 3de8a86
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
6 changes: 0 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,6 @@
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-logging</artifactId>
</dependency>
<dependency>
<!-- Not managed by opentelemetry-bom -->
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>1.30.0-rc.1</version>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-extension-autoconfigure</artifactId>
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/com/google/cloud/spanner/pgadapter/Server.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

package com.google.cloud.spanner.pgadapter;

import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_NAME;

import com.google.auth.Credentials;
import com.google.cloud.opentelemetry.metric.GoogleCloudMetricExporter;
import com.google.cloud.opentelemetry.metric.MetricConfiguration;
Expand All @@ -28,6 +26,7 @@
import com.google.devtools.cloudtrace.v2.AttributeValue;
import com.google.devtools.cloudtrace.v2.TruncatableString;
import io.opentelemetry.api.OpenTelemetry;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder;
Expand Down Expand Up @@ -246,7 +245,7 @@ static OpenTelemetry setupOpenTelemetry(OptionsMetadata optionsMetadata) {
}
builder.setFixedAttributes(
ImmutableMap.of(
SERVICE_NAME.getKey(),
"service.name",
AttributeValue.newBuilder()
.setStringValue(TruncatableString.newBuilder().setValue(serviceName).build())
.build()));
Expand Down Expand Up @@ -278,7 +277,9 @@ static OpenTelemetry setupOpenTelemetry(OptionsMetadata optionsMetadata) {
openTelemetryBuilder.addMeterProviderCustomizer(
(sdkMeterProviderBuilder, configProperties) ->
sdkMeterProviderBuilder
.addResource(Resource.create(Attributes.of(SERVICE_NAME, serviceName)))
.addResource(
Resource.create(
Attributes.of(AttributeKey.stringKey("service.name"), serviceName)))
.registerMetricReader(
PeriodicMetricReader.builder(cloudMonitoringExporter).build()));
}
Expand Down

0 comments on commit 3de8a86

Please sign in to comment.