Write inventory to attributes only if enabled #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
burov
commented
Sep 15, 2023
burov
commented
- Add enable-guest-attributes to the config.
- Write inventory to guest attributes only if guest attributes enabled.
|
/retest |
burov
force-pushed
the
fix_guest_attributes_inentory
branch
from
5b4d906 to
22e543e
Compare
|
/retest |
|
/packagebuild |
|
/retest |
|
Can you add a test for this please? |
Good point, i'm quite new to the test code for this packages, so i'm trying to set-up testing environment, so will do but it might take some time |
|
/packagebuild |
michaljankowiak
requested review from
michaljankowiak
and removed request for
vorakl and
koln67
|
/retest |
* Add enable-guest-attributes to the config. * Write inventory to guest attributes only if guest attributes enabled.
burov
force-pushed
the
fix_guest_attributes_inentory
branch
from
22e543e to
8cb1f4d
Compare
michaljankowiak
approved these changes
May 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: burov, michaljankowiak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/packagebuild |
google-oss-prow
bot
merged commit b73b439
into
GoogleCloudPlatform:master
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.